Make crash report IDs easy to copy #8540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 7, 2021 18:10
This enables a "click to copy crash report ID" feature in owncloud_crash_reporter. See dschmidt/libcrashreporter-qt#25 for more information.
Makes "make all" runs faster by excluding third-party targets, e.g., tests or libraries, which no other target in the main project links to, from building by default.
dschmidt
approved these changes
Apr 7, 2021
|
I'm not sure why the CI failed, but I'm relatively sure my changes are not the cause. @TheOneRing if you have a minute, could you please take a quick look? |
|
Yes fixing the ci. Just go ahead and merge 😊 |
fmoc
force-pushed
the
work/update-crashreporter
branch
from
d702301 to
c69d744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8130.
Updates libcrashreporter-qt submodule to the latest commit to include dschmidt/libcrashreporter-qt#25.
Also makes building
alltargets a little faster by excluding all targets from libcrashreporter-qt which are not explicitly linked by any other target. (They can still be buillt manually.)