-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac: Application should handle reopen #8812
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/applicationShouldHandleReopen
branch
from
July 22, 2021 10:19
23dc7e1
to
f38c6c6
Compare
erikjv
force-pushed
the
work/applicationShouldHandleReopen
branch
from
July 28, 2021 13:37
f38c6c6
to
8d46c9f
Compare
erikjv
changed the title
WIP: Work/application should handle reopen
Mac: Application should handle reopen
Jul 28, 2021
erikjv
force-pushed
the
work/applicationShouldHandleReopen
branch
3 times, most recently
from
July 29, 2021 09:34
a3f35f5
to
b834acf
Compare
TheOneRing
reviewed
Jul 29, 2021
TheOneRing
reviewed
Jul 29, 2021
Could you also add changelog entry like that one :) |
erikjv
force-pushed
the
work/applicationShouldHandleReopen
branch
from
July 29, 2021 15:01
b834acf
to
9630240
Compare
TheOneRing
reviewed
Jul 30, 2021
seemingly do nothing at all. To make this more consistent with other | ||
macOS applications, relaunching will now open the settings dialog. | ||
|
||
https://github.com/owncloud/client/pull/8812 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
https://github.com/owncloud/client/pull/8812 | |
https://github.com/owncloud/client/issues/8377 | |
https://github.com/owncloud/client/pull/8812 |
erikjv
force-pushed
the
work/applicationShouldHandleReopen
branch
from
July 30, 2021 09:21
9630240
to
a159421
Compare
erikjv
force-pushed
the
work/applicationShouldHandleReopen
branch
from
July 30, 2021 09:24
a159421
to
9202a79
Compare
TheOneRing
approved these changes
Jul 30, 2021
Please retry analysis of this Pull-Request directly on SonarCloud. |
dragotin
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.