Remove support for client side certificates

changelog/unreleased/8864

@@ -0,0 +1,5 @@
+Bugfix: Removed support for client side certificates
+
+Client side certificates where never officially supported and where untested in many scenarios.
+
+https://github.com/owncloud/client/pull/8864

src/cmd/cmd.cpp

@@ -274,9 +274,8 @@ class HttpCredentialsText : public HttpCredentials
 {
 public:
     HttpCredentialsText(const QString &user, const QString &password)
-        : HttpCredentials(DetermineAuthTypeJob::AuthType::Basic ,user, password)
-        , // FIXME: not working with client certs yet (qknight)
-        _sslTrusted(false)
+        : HttpCredentials(DetermineAuthTypeJob::AuthType::Basic, user, password)
+        , _sslTrusted(false)
     {
     }
 

src/gui/CMakeLists.txt

@@ -21,7 +21,6 @@ set(client_UI_SRCS
     shareusergroupwidget.ui
     shareuserline.ui
     sslerrordialog.ui
-    addcertificatedialog.ui
     proxyauthdialog.ui
     notificationwidget.ui
     logbrowser.ui
@@ -75,7 +74,6 @@ set(client_SRCS
     thumbnailjob.cpp
     quotainfo.cpp
     accountstate.cpp
-    addcertificatedialog.cpp
     authenticationdialog.cpp
     proxyauthhandler.cpp
     proxyauthdialog.cpp

src/gui/accountstate.cpp

@@ -257,7 +257,7 @@ void AccountState::checkConnectivity(bool blockJobs)
     }
 
     // If we never fetched credentials, do that now - otherwise connection attempts
-    // make little sense, we might be missing client certs.
+    // make little sense.
     if (!account()->credentials()->wasFetched()) {
         _waitingForNewCredentials = true;
         account()->credentials()->fetchFromKeychain();