Skip to content

Commit

Permalink
Merge pull request #38969 from owncloud/add-api-test-lock-breaker-group
Browse files Browse the repository at this point in the history 
[full-ci][tests-only] add api tests for lock breaker group
  • Loading branch information
@phil-davis
phil-davis authored Jul 13, 2021
2 parents 7434ebf + e69a9b9 commit d399238
Show file tree
Hide file tree
Showing 3 changed files with 371 additions and 2 deletions.
314 changes: 314 additions & 0 deletions tests/acceptance/features/apiWebdavLocksUnlock/lockBreakersGroups.feature
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,314 @@
@api
Feature: UNLOCK locked items

Background:
Given user "Alice" has been created with default attributes and without skeleton files


Scenario Outline: a group can be added as a lock breaker group
Given using <dav-path> DAV path
And group "grp1" has been created
When the administrator sets parameter "lock-breaker-groups" of app "core" to '["grp1"]'
Then the HTTP status code should be "200"
And group "grp1" should exist as a lock breaker group
Examples:
| dav-path |
| old |
| new |


Scenario Outline: more than one group can be added as a lock breaker group
Given using <dav-path> DAV path
And group "grp1" has been created
And group "grp2" has been created
When the administrator sets parameter "lock-breaker-groups" of app "core" to '["grp1","grp2"]'
Then the HTTP status code should be "200"
And following groups should exist as lock breaker groups
| groups |
| grp1 |
| grp2 |
Examples:
| dav-path |
| old |
| new |


Scenario Outline: member of the lock breakers group can unlock a locked folder shared with them
Given using <dav-path> DAV path
And group "grp1" has been created
And user "Brian" has been created with default attributes and without skeleton files
And user "Alice" has created folder "FOLDER"
And parameter "lock-breaker-groups" of app "core" has been set to '["grp1"]'
And user "Brian" has been added to group "grp1"
And user "Alice" has locked folder "FOLDER" setting the following properties
| lockscope | <lock-scope> |
And user "Alice" has shared folder "FOLDER" with user "Brian"
When user "Brian" unlocks folder "FOLDER" with the last created lock of folder "FOLDER" of user "Alice" using the WebDAV API
Then the HTTP status code should be "204"
And 0 locks should be reported for folder "FOLDER" of user "Brian" by the WebDAV API
And 0 locks should be reported for folder "FOLDER" of user "Alice" by the WebDAV API
Examples:
| dav-path | lock-scope |
| old | shared |
| old | exclusive |
| new | shared |
| new | exclusive |


Scenario Outline: members of the lock breakers group can unlock a locked folder shared with them and lock it back again
Given using <dav-path> DAV path
And group "grp1" has been created
And user "Brian" has been created with default attributes and without skeleton files
And user "Alice" has created folder "FOLDER"
And parameter "lock-breaker-groups" of app "core" has been set to '["grp1"]'
And user "Brian" has been added to group "grp1"
And user "Alice" has locked folder "FOLDER" setting the following properties
| lockscope | <lock-scope> |
And user "Alice" has shared folder "FOLDER" with user "Brian"
When user "Brian" unlocks folder "FOLDER" with the last created lock of folder "FOLDER" of user "Alice" using the WebDAV API
Then the HTTP status code should be "204"
And 0 locks should be reported for folder "FOLDER" of user "Brian" by the WebDAV API
When user "Brian" locks folder "FOLDER" using the WebDAV API setting the following properties
| lockscope | <lock-scope> |
Then the HTTP status code should be "200"
And 1 locks should be reported for folder "FOLDER" of user "Brian" by the WebDAV API
Examples:
| dav-path | lock-scope |
| old | shared |
| old | exclusive |
| new | shared |
| new | exclusive |


Scenario Outline: members of the lock breakers group can unlock a locked file shared with them
Given using <dav-path> DAV path
And group "grp1" has been created
And user "Brian" has been created with default attributes and without skeleton files
And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "textfile0.txt"
And parameter "lock-breaker-groups" of app "core" has been set to '["grp1"]'
And user "Brian" has been added to group "grp1"
And user "Alice" has locked file "textfile0.txt" setting the following properties
| lockscope | <lock-scope> |
And user "Alice" has shared file "textfile0.txt" with user "Brian"
When user "Brian" unlocks file "textfile0.txt" with the last created lock of file "textfile0.txt" of user "Alice" using the WebDAV API
Then the HTTP status code should be "204"
And 0 locks should be reported for file "textfile0.txt" of user "Brian" by the WebDAV API
And 0 locks should be reported for file "textfile0.txt" of user "Alice" by the WebDAV API
Examples:
| dav-path | lock-scope |
| old | shared |
| old | exclusive |
| new | shared |
| new | exclusive |


Scenario Outline: members of the lock breakers group can unlock a locked file shared with them and lock it back again
Given using <dav-path> DAV path
And group "grp1" has been created
And user "Brian" has been created with default attributes and without skeleton files
And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "textfile0.txt"
And parameter "lock-breaker-groups" of app "core" has been set to '["grp1"]'
And user "Brian" has been added to group "grp1"
And user "Alice" has locked file "textfile0.txt" setting the following properties
| lockscope | <lock-scope> |
And user "Alice" has shared file "textfile0.txt" with user "Brian"
When user "Brian" unlocks file "textfile0.txt" with the last created lock of file "textfile0.txt" of user "Alice" using the WebDAV API
Then the HTTP status code should be "204"
And 0 locks should be reported for file "textfile0.txt" of user "Brian" by the WebDAV API
When user "Brian" locks file "textfile0.txt" using the WebDAV API setting the following properties
| lockscope | <lock-scope> |
Then the HTTP status code should be "200"
And 1 locks should be reported for file "textfile0.txt" of user "Brian" by the WebDAV API
And 1 locks should be reported for file "textfile0.txt" of user "Alice" by the WebDAV API
Examples:
| dav-path | lock-scope |
| old | shared |
| old | exclusive |
| new | shared |
| new | exclusive |


Scenario Outline: as a member of lock breaker group unlocking a file in a share locked by the file owner is possible
Given using <dav-path> DAV path
And group "grp1" has been created
And user "Brian" has been created with default attributes and without skeleton files
And parameter "lock-breaker-groups" of app "core" has been set to '["grp1"]'
And user "Brian" has been added to group "grp1"
And user "Alice" has created folder "PARENT"
And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "PARENT/parent.txt"
And user "Alice" has locked file "PARENT/parent.txt" setting the following properties
| lockscope | <lock-scope> |
And user "Alice" has shared folder "PARENT" with user "Brian"
When user "Brian" unlocks file "PARENT/parent.txt" with the last created lock of file "PARENT/parent.txt" of user "Alice" using the WebDAV API
Then the HTTP status code should be "204"
And 0 locks should be reported for file "PARENT/parent.txt" of user "Alice" by the WebDAV API
And 0 locks should be reported for file "PARENT/parent.txt" of user "Brian" by the WebDAV API
Examples:
| dav-path | lock-scope |
| old | shared |
| old | exclusive |
| new | shared |
| new | exclusive |


Scenario Outline: as a member of lock breaker group unlocking a folder in a share locked by the folder owner is possible
Given using <dav-path> DAV path
And group "grp1" has been created
And user "Brian" has been created with default attributes and without skeleton files
And parameter "lock-breaker-groups" of app "core" has been set to '["grp1"]'
And user "Brian" has been added to group "grp1"
And user "Alice" has created folder "PARENT"
And user "Alice" has created folder "CHILD"
And user "Alice" has locked folder "PARENT/CHILD" setting the following properties
| lockscope | <lock-scope> |
And user "Alice" has shared folder "PARENT" with user "Brian"
When user "Brian" unlocks folder "PARENT/CHILD" with the last created lock of folder "PARENT/CHILD" of user "Alice" using the WebDAV API
Then the HTTP status code should be "204"
And 0 locks should be reported for folder "PARENT/CHILD" of user "Alice" by the WebDAV API
And 0 locks should be reported for folder "PARENT/CHILD" of user "Brian" by the WebDAV API
Examples:
| dav-path | lock-scope |
| old | shared |
| old | exclusive |
| new | shared |
| new | exclusive |


Scenario Outline: members of different lock breaker groups can lock and unlock same folder shared to them
Given using <dav-path> DAV path
And group "grp1" has been created
And group "grp2" has been created
And user "Brian" has been created with default attributes and without skeleton files
And user "Carol" has been created with default attributes and without skeleton files
And parameter "lock-breaker-groups" of app "core" has been set to '["grp1","grp2"]'
And user "Carol" has been added to group "grp2"
And user "Brian" has been added to group "grp1"
And user "Alice" has created folder "PARENT"
And user "Alice" has locked folder "PARENT" setting the following properties
| lockscope | <lock-scope> |
And user "Alice" has shared folder "PARENT" with user "Brian"
And user "Alice" has shared folder "PARENT" with user "Carol"
When user "Brian" unlocks folder "PARENT" with the last created lock of file "PARENT" of user "Alice" using the WebDAV API
Then the HTTP status code should be "204"
And 0 locks should be reported for folder "PARENT" of user "Alice" by the WebDAV API
And 0 locks should be reported for folder "PARENT" of user "Brian" by the WebDAV API
And 0 locks should be reported for folder "PARENT" of user "Carol" by the WebDAV API
When user "Brian" locks folder "PARENT" using the WebDAV API setting the following properties
| lockscope | <lock-scope> |
And 1 locks should be reported for folder "PARENT" of user "Alice" by the WebDAV API
And 1 locks should be reported for folder "PARENT" of user "Brian" by the WebDAV API
And 1 locks should be reported for folder "PARENT" of user "Carol" by the WebDAV API
Then the HTTP status code should be "200"
When user "Carol" unlocks folder "PARENT" with the last created lock of folder "PARENT" of user "Brian" using the WebDAV API
Then the HTTP status code should be "204"
And 0 locks should be reported for folder "PARENT" of user "Alice" by the WebDAV API
And 0 locks should be reported for folder "PARENT" of user "Brian" by the WebDAV API
And 0 locks should be reported for folder "PARENT" of user "Carol" by the WebDAV API
Examples:
| dav-path | lock-scope |
| old | shared |
| old | exclusive |
| new | shared |
| new | exclusive |


Scenario Outline: members of different lock breaker groups can lock and unlock same file shared to them
Given using <dav-path> DAV path
And group "grp1" has been created
And group "grp2" has been created
And user "Brian" has been created with default attributes and without skeleton files
And user "Carol" has been created with default attributes and without skeleton files
And parameter "lock-breaker-groups" of app "core" has been set to '["grp1","grp2"]'
And user "Carol" has been added to group "grp2"
And user "Brian" has been added to group "grp1"
And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "textfile0.txt"
And user "Alice" has locked file "textfile.txt" setting the following properties
| lockscope | <lock-scope> |
And user "Alice" has shared file "textfile.txt" with user "Brian"
And user "Alice" has shared file "textfile.txt" with user "Carol"
When user "Brian" unlocks file "textfile.txt" with the last created lock of file "textfile.txt" of user "Alice" using the WebDAV API
Then the HTTP status code should be "204"
And 0 locks should be reported for file "textfile.txt" of user "Alice" by the WebDAV API
And 0 locks should be reported for file "textfile.txt" of user "Brian" by the WebDAV API
And 0 locks should be reported for file "textfile.txt" of user "Carol" by the WebDAV API
When user "Brian" locks file "textfile.txt" using the WebDAV API setting the following properties
| lockscope | <lock-scope> |
And 1 locks should be reported for file "textfile.txt" of user "Alice" by the WebDAV API
And 1 locks should be reported for file "textfile.txt" of user "Brian" by the WebDAV API
And 1 locks should be reported for file "textfile.txt" of user "Carol" by the WebDAV API
Then the HTTP status code should be "200"
When user "Carol" unlocks file "textfile.txt" with the last created lock of file "textfile.txt" of user "Brian" using the WebDAV API
Then the HTTP status code should be "204"
And 0 locks should be reported for file "textfile.txt" of user "Alice" by the WebDAV API
And 0 locks should be reported for file "textfile.txt" of user "Brian" by the WebDAV API
And 0 locks should be reported for file "textfile.txt" of user "Carol" by the WebDAV API
Examples:
| dav-path | lock-scope |
| old | shared |
| old | exclusive |
| new | shared |
| new | exclusive |


Scenario Outline: members of lock breaker group can unlock a folder in group sharing
Given using <dav-path> DAV path
And group "grp1" has been created
And group "grp2" has been created
And user "Brian" has been created with default attributes and without skeleton files
And user "Carol" has been created with default attributes and without skeleton files
And parameter "lock-breaker-groups" of app "core" has been set to '["grp1"]'
And user "Carol" has been added to group "grp2"
And user "Brian" has been added to group "grp1"
And user "Brian" has been added to group "grp2"
And user "Alice" has created folder "PARENT"
And user "Alice" has locked folder "PARENT" setting the following properties
| lockscope | <lock-scope> |
And user "Alice" has shared folder "PARENT" with group "grp2"
When user "Carol" unlocks folder "PARENT" with the last created lock of folder "PARENT" of user "Alice" using the WebDAV API
Then the HTTP status code should be "403"
And 1 locks should be reported for folder "PARENT" of user "Alice" by the WebDAV API
And 1 locks should be reported for folder "PARENT" of user "Brian" by the WebDAV API
And 1 locks should be reported for folder "PARENT" of user "Carol" by the WebDAV API
When user "Brian" unlocks folder "PARENT" with the last created lock of file "PARENT" of user "Alice" using the WebDAV API
Then the HTTP status code should be "204"
And 0 locks should be reported for folder "PARENT" of user "Alice" by the WebDAV API
And 0 locks should be reported for folder "PARENT" of user "Brian" by the WebDAV API
And 0 locks should be reported for folder "PARENT" of user "Carol" by the WebDAV API
Examples:
| dav-path | lock-scope |
| old | shared |
| old | exclusive |
| new | shared |
| new | exclusive |


Scenario Outline: members of lock breaker group can unlock a file in group sharing
Given using <dav-path> DAV path
And group "grp1" has been created
And group "grp2" has been created
And user "Brian" has been created with default attributes and without skeleton files
And user "Carol" has been created with default attributes and without skeleton files
And parameter "lock-breaker-groups" of app "core" has been set to '["grp1"]'
And user "Carol" has been added to group "grp2"
And user "Brian" has been added to group "grp1"
And user "Brian" has been added to group "grp2"
And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "textfile0.txt"
And user "Alice" has locked file "textfile.txt0" setting the following properties
| lockscope | <lock-scope> |
And user "Alice" has shared file "textfile.txt0" with group "grp2"
When user "Carol" unlocks file "textfile.txt0" with the last created lock of file "textfile.txt0" of user "Alice" using the WebDAV API
Then the HTTP status code should be "403"
And 1 locks should be reported for file "textfile.txt0" of user "Alice" by the WebDAV API
And 1 locks should be reported for file "textfile.txt0" of user "Brian" by the WebDAV API
And 1 locks should be reported for file "textfile.txt0" of user "Carol" by the WebDAV API
When user "Brian" unlocks file "textfile.txt0" with the last created lock of file "textfile.txt0" of user "Alice" using the WebDAV API
Then the HTTP status code should be "204"
And 0 locks should be reported for file "textfile.txt0" of user "Alice" by the WebDAV API
And 0 locks should be reported for file "textfile.txt0" of user "Brian" by the WebDAV API
And 0 locks should be reported for file "textfile.txt0" of user "Carol" by the WebDAV API
Examples:
| dav-path | lock-scope |
| old | shared |
| old | exclusive |
| new | shared |
| new | exclusive |
7 changes: 5 additions & 2 deletions tests/acceptance/features/bootstrap/AppConfigurationContext.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class AppConfigurationContext implements Context {
private $featureContext;

/**
* @When /^the administrator sets parameter "([^"]*)" of app "([^"]*)" to "([^"]*)"$/
* @When /^the administrator sets parameter "([^"]*)" of app "([^"]*)" to ((?:'[^']*')|(?:"[^"]*"))$/
*
* @param string $parameter
* @param string $app
Expand All @@ -53,6 +53,9 @@ public function adminSetsServerParameterToUsingAPI(
$app,
$value
) {
// The capturing group of the regex always includes the quotes at each
// end of the captured string, so trim them.
$value = \trim($value, $value[0]);
$this->modifyAppConfig($app, $parameter, $value);
}

Expand All @@ -72,7 +75,7 @@ public function serverParameterHasBeenSetTo($parameter, $app, $value) {
return;
}
$value = \trim($value, $value[0]);
$this->adminSetsServerParameterToUsingAPI($parameter, $app, $value);
$this->modifyAppConfig($app, $parameter, $value);
}

/**
Expand Down
Loading

0 comments on commit d399238

Please sign in to comment.