Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions downloaded of shared files are named with a number instead of the filename #36228

Closed
davitol opened this issue Oct 1, 2019 · 5 comments · Fixed by #39314
Closed
Assignees
Milestone

Comments

@davitol
Copy link
Contributor

davitol commented Oct 1, 2019

Steps to reproduce

  1. create a file (e.g docx)
  2. Edit it and create a version
  3. Share the file with userB
  4. Login with userB
  5. Browse to the SideBar and download a file version

Expected behaviour

File's name should be preserved

Actual behaviour

Files is downloaded named as a number

Database:
MySQL

ownCloud version: (see ownCloud admin page)

oC 10 10.3.0RC1

@davitol davitol added this to the QA milestone Oct 1, 2019
@phil-davis
Copy link
Contributor

phil-davis commented Jun 28, 2021

This is still an issue. As receiver of the shared file, I get an old version downloaded with a name like 1624854121.txt

Note: As receiver of a shared folder, I can download old versions of files in the folder, and I get the correct file names.

The UI is sending a request to something like:
http://172.17.0.1:8080/remote.php/dav/meta/2147484945/v/1624854120

@dpakach someone should first check that there are API tests that cover this - I see that FilesVersionsContext.php has references to path /meta/$fileId/v - there need to be API tests that cover the share receiver downloading previous versions of a received file. (and downloading previous versions of a file that is in a received folder)

And once we have API tests that we know are passing, then it might be a UI problem, and we can make a UI test that demonstrates this.

@individual-it individual-it self-assigned this Jun 30, 2021
@individual-it
Copy link
Member

I think the issue is the Content-Disposition Header
downloading a n older version of an own file gives: attachment; filename*=UTF-8''block-aligned.txt; filename="block-aligned.txt"
but in a shared case: attachment; filename*=UTF-8''; filename=""

@individual-it
Copy link
Member

I don't think we have any API tests trying to download old versions

@individual-it
Copy link
Member

tests added in #38921

@AlexAndBear
Copy link

@JammingBen Still exists, should be name like in users file list (keep in mind, that the user can rename a shared file)

JammingBen added a commit that referenced this issue Oct 1, 2021
Fix file version names for share recipients
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants