Event dispatcher

[DeepDiver1975]

@PVince81 @MorrisJobke @Raydiation @PVince81 @Raydiation

[PVince81]

Looks nice.

We have a few other places in core where we'd need that.

By the way: in what way would this affect the assets pipeline ? Would there be two JS bundles one with the extra scripts and one without ?

[PVince81]

We could actually dispatch a similar event after "app.php" of any app has run. Not sure about the performance though if we do it for each app in every request...

[DeepDiver1975]

By the way: in what way would this affect the assets pipeline ? Would there be two JS bundles one with the extra scripts and one without ?

Not at all from my understanding - all scripts/styles will be summed up during rendering of the template. And the version hash of the assembled files will change based on the files included.

[RobinMcCorkell]

Death to the hooks! I like this 😄

[RobinMcCorkell]

I'm guessing this is example code and isn't actually supposed to be run? Otherwise it seems odd the dispatch call is above

[MorrisJobke]

I don't get it. In this case the dispatch happens before the registration of the listeners. So the listener isn't called. Or am I totally wrong and missunderstood the EventDispatcher?

[PVince81]

@MorrisJobke this block is supposed to be in the activity app's appinfo/app.php.
@DeepDiver1975 has added it only to show an example. That must be removed before merging.

[MorrisJobke]

I guess this will completely mess up once the apps are not loaded in the correct order.

[DeepDiver1975]

sure - this will go into the activity app

[DeepDiver1975]

We could actually dispatch a similar event after "app.php" of any app has run. Not sure about the performance though if we do it for each app in every request...

We have to do this slightly different

1. load all apps
2. emit the app-loaded hook for all of them

Otherwise an app being loaded later cannot react on a loaded event of a previous app

[PVince81]

Anyway, I'm fine with the current approach for now.
Then we can adapt all files_* apps to load their scripts in that handler instead of app.php.

[RobinMcCorkell]

👍

[BernhardPosselt]

👍

[PVince81]

👍

[DeepDiver1975]

Let me squash the last two commits later before merge ...

[PVince81]

@DeepDiver1975 time to squash

[PVince81]

Please fix the commit text

[scrutinizer-notifier]

A new inspection was created.

[PVince81]

👍

[DeepDiver1975]

@owncloud-bot 👽

[ghost]

🚀 Test PASSed.🚀

[MorrisJobke]

@owncloud-bot retest this please

[ghost]

🚀 Test PASSed.🚀