Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 20200221 #37004

Closed
wants to merge 13 commits into from
Closed

PHP 7.4 20200221 #37004

wants to merge 13 commits into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 21, 2020

This is code so far for supporting PHP 7.4

This PR is on top of #36999 which implements Guzzle6 for acceptance tests. That can help developers who have PHP 7.4 - they can run acceptance tests against some ownCloud system-under-test (ownCloud10 itself, or OCIS or...)

PR #36999 "Guzzle6 for acceptance tests" is now in master. I have rebased this PR.

There are a lot of adjustments to phpunit tests still to be done - but I think the actual run-time back-end works.

@phil-davis phil-davis self-assigned this Feb 21, 2020
@owncloud owncloud deleted a comment from update-docs bot Feb 21, 2020
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #37004 into master will increase coverage by 0.73%.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37004      +/-   ##
============================================
+ Coverage     64.75%   65.48%   +0.73%     
- Complexity    19138    19301     +163     
============================================
  Files          1270     1223      -47     
  Lines         74912    71909    -3003     
  Branches       1329     1329              
============================================
- Hits          48507    47090    -1417     
+ Misses        26014    24428    -1586     
  Partials        391      391
Flag Coverage Δ Complexity Δ
#javascript 54.17% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.8% <20%> (+0.87%) 19301 <0> (+163) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Cache.php 95.87% <ø> (-1.77%) 106 <0> (ø)
index.php 0% <0%> (ø) 0 <0> (ø) ⬇️
console.php 0% <0%> (ø) 0 <0> (ø) ⬇️
...AppFramework/Utility/ControllerMethodReflector.php 100% <100%> (ø) 10 <0> (ø) ⬇️
lib/private/DB/SQLiteSessionInit.php 0% <0%> (-100%) 4% <0%> (ø)
lib/private/DB/SQLiteMigrator.php 0% <0%> (-100%) 7% <0%> (ø)
lib/private/DB/AdapterOCI8.php 0% <0%> (-86.67%) 4% <0%> (ø)
...ivate/Files/ObjectStore/HomeObjectStoreStorage.php 0% <0%> (-86.67%) 8% <0%> (ø)
lib/private/Repair/SqliteAutoincrement.php 0% <0%> (-85.19%) 9% <0%> (ø)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 0% <0%> (-85.19%) 18% <0%> (ø)
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965950e...73c714a. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Note:
litmus and webDAV problem with object __toString conversion exception - see #32670 (comment)

@phil-davis
Copy link
Contributor Author

See #37101

@phil-davis phil-davis closed this Mar 10, 2020
@phil-davis phil-davis deleted the php7.4-20200221 branch June 18, 2020 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant