Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Do not run Oracle issue 37026 in CI #37312

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Apr 27, 2020

Description

A new acceptance test scenario was added in PR #37296 to demonstrate an issue when running with Oracle database. It now seems that the problem is intermittent. This means that CI in master "randomly" fails, which is annoying! See #37026 (comment)

For now, do not run this scenario in CI. It will still be in the acceptance test feature file, and might be of some help to whoever looks into the detail of the problem.

Related Issue

Part of #37026

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #37312 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37312   +/-   ##
=========================================
  Coverage     64.53%   64.53%           
  Complexity    19166    19166           
=========================================
  Files          1266     1266           
  Lines         74952    74952           
  Branches       1331     1331           
=========================================
  Hits          48372    48372           
  Misses        26188    26188           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.69% <ø> (ø) 19166.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0559c10...9d08efa. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #37312 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37312   +/-   ##
=========================================
  Coverage     64.53%   64.53%           
  Complexity    19166    19166           
=========================================
  Files          1266     1266           
  Lines         74952    74952           
  Branches       1331     1331           
=========================================
  Hits          48372    48372           
  Misses        26188    26188           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.69% <ø> (ø) 19166.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0559c10...9d08efa. Read the comment docs.

@phil-davis phil-davis merged commit 5ebef8a into master Apr 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the do-not-run-issue-37026-in-CI branch April 27, 2020 13:01
@phil-davis phil-davis mentioned this pull request May 4, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants