Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Skip meta username test on 10.4 #37349

Merged
merged 1 commit into from
May 6, 2020

Conversation

phil-davis
Copy link
Contributor

Description

PR #37268 added code that prohibits certain special usernames. The acceptance test that was added will only work in 10.5 onwards. Skip it on older ownCloud versions.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #37349 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37349   +/-   ##
=========================================
  Coverage     64.55%   64.55%           
  Complexity    19217    19217           
=========================================
  Files          1268     1268           
  Lines         75100    75100           
  Branches       1331     1331           
=========================================
  Hits          48478    48478           
  Misses        26230    26230           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.70% <ø> (ø) 19217.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49797b8...c22f098. Read the comment docs.

@individual-it individual-it merged commit e5ab8b0 into master May 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the skip-meta-username-test-on-10.4 branch May 6, 2020 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants