-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OcsController in provisioning_api routes #37382
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
739bc51
to
4ce1808
Compare
2569e6a
to
c9015b7
Compare
641d013
to
fcbfdce
Compare
Codecov Report
@@ Coverage Diff @@
## master #37382 +/- ##
============================================
- Coverage 64.75% 64.73% -0.02%
- Complexity 19408 19423 +15
============================================
Files 1285 1287 +2
Lines 75830 75856 +26
Branches 1336 1336
============================================
+ Hits 49101 49108 +7
- Misses 26335 26354 +19
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
392fbfa
to
e745d95
Compare
e745d95
to
6b41735
Compare
6b41735
to
c958f7b
Compare
old aka dead -> close |
Description
Related Issue
#12454
Motivation and Context
How Has This Been Tested?
Acceptance and unit tests
Known issues / TODO:
997
but403
for unauthorized users - custom security middleware neededContent-Type: application/json
,Content-Type: application/x-www-form-urlencoded
or non-empty request body due to https://github.com/owncloud/core/blob/7ded2889df85c6c049a90f3aff8bc8b7bcc96fb7/lib/private/AppFramework/Http/Request.php#L390-399 - blocked by Allow reading params of PUT with empty body more than once #37394e.g.
curl -X PUT http://admin:admin@/oc/ocs/v1.php/cloud/users/user1/disable -H 'Content-Type: application/json'
worksbut
curl -X PUT http://admin:admin@/oc/ocs/v1.php/cloud/users/user1/disable
does NOTTypes of changes
Checklist: