Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OcsController in provisioning_api routes #37382

Closed
wants to merge 5 commits into from
Closed

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented May 12, 2020

Description

Related Issue

#12454

Motivation and Context

How Has This Been Tested?

Acceptance and unit tests

Known issues / TODO:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@VicDeo VicDeo self-assigned this May 12, 2020
@update-docs
Copy link

update-docs bot commented May 12, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@VicDeo VicDeo force-pushed the provisioning-routes branch 10 times, most recently from 739bc51 to 4ce1808 Compare May 13, 2020 15:25
@VicDeo VicDeo force-pushed the provisioning-routes branch from 2569e6a to c9015b7 Compare May 14, 2020 10:45
@VicDeo VicDeo marked this pull request as ready for review May 14, 2020 14:25
@VicDeo VicDeo force-pushed the provisioning-routes branch 3 times, most recently from 641d013 to fcbfdce Compare May 16, 2020 00:11
@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #37382 (c958f7b) into master (b962fb4) will decrease coverage by 0.01%.
The diff coverage is 84.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37382      +/-   ##
============================================
- Coverage     64.75%   64.73%   -0.02%     
- Complexity    19408    19423      +15     
============================================
  Files          1285     1287       +2     
  Lines         75830    75856      +26     
  Branches       1336     1336              
============================================
+ Hits          49101    49108       +7     
- Misses        26335    26354      +19     
  Partials        394      394              
Flag Coverage Δ Complexity Δ
javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
phpunit 65.91% <84.21%> (-0.02%) 0.00 <148.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
apps/provisioning_api/lib/AppInfo/Application.php 53.84% <53.84%> (ø) 1.00 <1.00> (?)
...provisioning_api/lib/Controller/AppsController.php 64.51% <64.51%> (ø) 10.00 <10.00> (?)
...ning_api/lib/Middleware/ProvisioningMiddleware.php 70.83% <70.83%> (ø) 13.00 <13.00> (?)
...ovisioning_api/lib/Controller/GroupsController.php 93.58% <87.50%> (ø) 31.00 <31.00> (?)
...rovisioning_api/lib/Controller/UsersController.php 90.55% <98.70%> (ø) 119.00 <93.00> (?)
apps/provisioning_api/appinfo/routes.php 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
lib/private/AppFramework/Http/Request.php 91.75% <100.00%> (ø) 143.00 <0.00> (ø)
lib/public/App.php 12.50% <0.00%> (-12.50%) 7.00% <0.00%> (ø%)
lib/private/Share/MailNotifications.php 95.69% <0.00%> (-0.05%) 32.00% <0.00%> (-1.00%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b962fb4...c958f7b. Read the comment docs.

@VicDeo VicDeo force-pushed the provisioning-routes branch 3 times, most recently from 392fbfa to e745d95 Compare May 25, 2020 08:28
@VicDeo VicDeo force-pushed the provisioning-routes branch from e745d95 to 6b41735 Compare June 15, 2020 09:43
@VicDeo VicDeo force-pushed the provisioning-routes branch from 6b41735 to c958f7b Compare September 16, 2020 11:15
@DeepDiver1975
Copy link
Member

old aka dead -> close

@DeepDiver1975 DeepDiver1975 deleted the provisioning-routes branch January 4, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants