[Tests-Only] Adds API tests for counting number of etag elements in response of a versioned file #38439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwikritiT
force-pushed
the
versionCount
branch
3 times, most recently
from
b134316 to
d17a4f5
Compare
Talank
reviewed
Feb 24, 2021
| And user "Alice" has uploaded file with content "version 2" to "textfile0.txt" | ||
| When user "Alice" gets the number of versions of file "textfile0.txt" | ||
| Then the HTTP status code should be "207" | ||
| And the number of etag element in the response should be "2" |
There was a problem hiding this comment.
Also, check the number of d:getlastmodified tags as you have specified in the scenario title.
SwikritiT
commented
Feb 24, 2021
| When user "Alice" gets the number of versions of file "textfile0.txt" | ||
| Then the HTTP status code should be "207" | ||
| And the number of etag element in the response should be "2" | ||
| And the number of versions should be "2" |
There was a problem hiding this comment.
@Talank this checks the version by counting d:getlastmodified so I thought that wouldn't be necessary. Maybe I should rephrase the scenario title.
saw-jan
reviewed
Feb 24, 2021
| @@ -448,6 +448,31 @@ public function theNumberOfVersionsShouldBe($number) { | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * @Then the number of etag element in the response should be :arg1 | |||
There was a problem hiding this comment.
Suggested change
| * @Then the number of etag element in the response should be :arg1 | |
| * @Then the number of etag element in the response should be :number |
If you wish you can change it to something meaningful like this
else LGTM 👍
SwikritiT
force-pushed
the
versionCount
branch
from
89e83b6 to
2ccc95d
Compare
individual-it
requested changes
Feb 24, 2021
| @@ -448,6 +448,31 @@ public function theNumberOfVersionsShouldBe($number) { | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * @Then the number of etag element in the response should be :number | |||
There was a problem hiding this comment.
Suggested change
| * @Then the number of etag element in the response should be :number | |
| * @Then the number of etag elements in the response should be :number |
| Assert::assertEquals( | ||
| $number, | ||
| $actualNumber, | ||
| "Expected number of etag element was '$number', but got '$actualNumber'" |
There was a problem hiding this comment.
Suggested change
| "Expected number of etag element was '$number', but got '$actualNumber'" | |
| "Expected number of etag elements was '$number', but got '$actualNumber'" |
SwikritiT
force-pushed
the
versionCount
branch
from
2ccc95d to
29b947c
Compare
SwikritiT
force-pushed
the
versionCount
branch
from
29b947c to
bf0d952
Compare
individual-it
approved these changes
Feb 25, 2021
SwikritiT
force-pushed
the
versionCount
branch
from
bf0d952 to
f6fddca
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds API tests for counting number of etag elements in response of a versioned file
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: