[Tests-Only] Add acceptance tests for resharing deleted file #38490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Talank
suggested changes
Mar 11, 2021
Comment on lines
219
to
221
| | ocs_api_version | ocs_status_code | http_status_code | | ||
| | 1 | 100 | 200 | | ||
| | 2 | 200 | 200 | |
There was a problem hiding this comment.
since the HTTP status code is 200 in both examples, you do not need to keep it in the example table.
dpakach
force-pushed
the
test-reshare-deleted
branch
from
4940620 to
e218665
Compare
Talank
approved these changes
Mar 11, 2021
individual-it
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
is the bug described in owncloud/ocis#1787 also reproducible with files?
@kulmann mentioning sharing of folders.
maybe we could add also a test with sharing a folder
dpakach
force-pushed
the
test-reshare-deleted
branch
from
e218665 to
e5db707
Compare
individual-it
approved these changes
Mar 12, 2021
dpakach
force-pushed
the
test-reshare-deleted
branch
from
e5db707 to
76718fc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add acceptance tests for resharing a deleted file.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: