Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Tag new share expiration date test notToImplementOnOCIS #39110

Merged
merged 1 commit into from
Aug 13, 2021
Merged

[tests-only] Tag new share expiration date test notToImplementOnOCIS #39110

merged 1 commit into from
Aug 13, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 13, 2021 •
edited
Loading

Description

This new public link share expiration test scenario was added in PR #39100

Other share expiration tests are currently tagged notToImplementOnOCIS. So also tag this one.

Next week we can sort out what to do about owncloud/ocis#1250 - issue about share expiration dates in oCIS - how to tag better, and run or not run in oCIS. That is a good example of a feature that is yet to be implemented in oCIS.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Aug 13, 2021
@phil-davis phil-davis requested a review from saw-jan August 13, 2021 05:24
@phil-davis phil-davis mentioned this pull request Aug 13, 2021
Closed
9 tasks
@phil-davis phil-davis requested a review from dpakach August 13, 2021 05:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis merged commit a48be97 into master Aug 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the tag-expiration-date-test-notToImplementOnOCIS branch August 13, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@dpakach dpakach Awaiting requested review from dpakach

Assignees

@phil-davis phil-davis

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @saw-jan