[tests-only] Nodejs 14

[phil-davis]

Description

owncloud-ci/nodejs#44 added libfontconfig to owncloudci/nodejs - that is a dependency that PhantomJS needs in the JS unit tests. That allows the JS unit tests to run using the owncloudci/nodejs:14 docker image.

1. Bump to nodejs 14 in build/package.json
2. Use nodejs 14 when installing with owncloudci/core (that image was added in PR Add image with nodejs14 owncloud-ci/core#28 )
3. Use owncloudci/nodejs:14 to run test-js (PR Install libfontconfig that is required for PhantomJS owncloud-ci/nodejs#44 updated owncloudci/nodejs so that PhantomJS works in the JS unit tests)

AFAICT all uses of nodejs in CI are now using V14.

Related Issue

owncloud-ci/php#137

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[phil-davis]

https://drone.owncloud.com/owncloud/core/31988/10/4

Warning: Accessing non-existent property 'VERSION' of module exports inside circular dependency

The last commit updates build/yarn.lock which gets rid of that warning.

To update build/yarn.lock I had to delete it and then yarn install from the build dir.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[pascalwengerter]

Technically LGTM and CI seems to be happy - but is there a specific reason you're using the nodeJsVersion in one place and hardcoded versions in the others?

[phil-davis]

@pascalwengerter owncloudci/core docker image has a tag called nodejs14
owncloudci/nodejs has a tag called 14.

owncloudci/core is an image that "knows" how to fetch oC10 core from somewhere and install it. In the case of installing from a git reference, it needs to do the PHP and the JavaScript dependencies stuff itself. So it needs all the tools available (PHP, composer, JavaScript, nodejs...). We didn't want to modify the versions of tools that are in the latest tag, because that might break lots of existing CI. To provide a way forward, we made a tag called nodejs14. Hopefully when all CI is updated, we will have a clear picture of what is needed for owncloudci/core and if there really are different tool-versions combinations required, then we will have to sort out a naming scheme for them.