[tests-only] Fix Guzzle7 exception handling in HttpRequestHelper #39251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
getResponse()
method was removed fromGuzzleHttp\Exception\ConnectException
in Guzzle7.It still exists in
GuzzleHttp\Exception\RequestException
So not all exceptions have a
getResponse()
method. Be more careful to only try to process aRequestException
and check for a response. Do not catch other exceptions. They will throw higher up and eventually Behat will catch them and fail the test scenario and report the exception.Related Issue
How Has This Been Tested?
CI - although the exception handling only happens in unusual circumstances.
Types of changes
Checklist: