Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Add tests to demonstrate group names with leading and trailing spaces #39530

Closed
wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

Description

This adds extra acceptance test scenarios that demonstrate the current behavior when adding groups with leading or trailing spaces in the name, or the group name " " (a single space).

Needs input about if the current behavior or some different behavior is required.

Related Issue

https://github.com/owncloud/enterprise/issues/4890

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Nov 25, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

Note: these extra tests have been cherry-picked to #39514 so that they will be merged to master some time.

@phil-davis
Copy link
Contributor Author

Note: PR #39540 contains a suggested solution with oC10 code changes and tests. If that is acceptable then we can make those changes to oC10 and make oCIS behave the same.

@phil-davis
Copy link
Contributor Author

Merged to master in #39612

@phil-davis phil-davis closed this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant