Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand area filename area to min size in file list #39592

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Expand area filename area to min size in file list #39592

merged 1 commit into from
Dec 14, 2021

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Dec 14, 2021 •
edited
Loading

Description

Enhancement: Expand file name area to click

With this change, the file name area to click will expand, this is helpful
with very small file or folder names (e.G single digit).

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@owncloud owncloud deleted a comment from update-docs bot Dec 14, 2021
@AlexAndBear AlexAndBear marked this pull request as ready for review December 14, 2021 09:53
@phil-davis
Copy link
Contributor

phil-davis commented Dec 14, 2021 •
edited
Loading

file-extension-separated

For files with short names, the file extension is away from the file name.
A folder with a "file extension" seems to render OK.

@AlexAndBear
Copy link
Author

@phil-davis THX, good catch, fixed.

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProvisioning-v2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/55/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareUpdateToRoot-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/79/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiOnSqlite-sqlite-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/178/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareReshareToShares1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/74/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiSharePublicLink1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/71/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareReshareToRoot2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/75/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliTrashbin-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/118/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProvisioning-v1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/54/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProxySmoke-8-2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/171/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIFiles-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/129/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIUpload-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/150/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProxySmoke-8-8-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/177/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUISharingExt2-git-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/158/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUISharingIntUsers2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/145/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProxySmoke-8-1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/170/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIFfSmoke-3-1-firefox-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/161/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIMobileSize-3-2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/168/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIProxySmoke-3-1-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34022/164/1

@phil-davis
Copy link
Contributor

phil-davis commented Dec 14, 2021 •
edited
Loading

@phil-davis THX, good catch, fixed.

file-extension-fixed

Looks good now.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit bdff4e3 into master Dec 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/39591 branch December 14, 2021 12:13
@phil-davis phil-davis mentioned this pull request Dec 15, 2021
Merged
11 tasks
@jnweiger
Copy link
Contributor

Confirmed fixed in 10.9.0 RC2 -- that was quick. Thank you!

JammingBen added a commit that referenced this pull request Dec 21, 2021
@JammingBen
Remove the already released changelog #39592 from the unreleased list
d37308e
@JammingBen JammingBen mentioned this pull request Dec 21, 2021
Merged
6 tasks
JammingBen added a commit that referenced this pull request Dec 21, 2021
@JammingBen
Merge pull request #39611 from owncloud/remove-unrelease-changelog
88d3b86 
Remove the already released changelog #39592 from the unreleased list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis left review comments

@JammingBen JammingBen JammingBen approved these changes

Assignees

@AlexAndBear AlexAndBear

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Folders with very short names are hard to open in Web UI
5 participants
@AlexAndBear @phil-davis @ownclouders @jnweiger @JammingBen