Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Test with Oracle #39755

Closed
wants to merge 2 commits into from
Closed

Conversation

phil-davis
Copy link
Contributor

Issue #37026

This is a CI run the same as PR #39637 - there have been various changes in core in the last month or so, so this will check the behavior of core with Oracle.

Do not merge - test only.

@phil-davis
Copy link
Contributor Author

phil-davis commented Feb 7, 2022

https://drone.owncloud.com/owncloud/core/34542/70/13

runsh: Total unexpected failed scenarios throughout the test run:
apiShareOperationsToShares2/shareAccessByID.feature:50
apiShareOperationsToShares2/shareAccessByID.feature:51
apiShareOperationsToShares2/shareAccessByID.feature:52
apiShareOperationsToShares2/shareAccessByID.feature:53
  Scenario Outline: Get a share with an invalid share id                    # /drone/src/tests/acceptance/features/apiShareOperationsToShares2/shareAccessByID.feature:40
    Given using OCS API version "<ocs_api_version>"                         # FeatureContext::usingOcsApiVersion()
    When user "Alice" gets share with id "<share_id>" using the sharing API # FeatureContext::userGetsTheLastShareWithTheShareIdUsingTheSharingApi()
    Then the OCS status code should be "404"                                # OCSContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "<http_status_code>"                 # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the API should not return any data                                  # FeatureContext::theApiShouldNotReturnAnyData()
    Examples:
      | ocs_api_version | share_id   | http_status_code |
      | 1               | 2333311    | 200              |
      | 2               | 2333311    | 404              |
      | 1               | helloshare | 200              |
        OCS status code is not any of the expected values 404 got 996
        Failed asserting that an array contains '996'.
      | 2               | helloshare | 404              |
        OCS status code is not any of the expected values 404 got 500
        Failed asserting that an array contains '500'.
      | 1               | $#@r3      | 200              |
        OCS status code is not any of the expected values 404 got 996
        Failed asserting that an array contains '996'.
      | 2               | $#@r3      | 404              |
        OCS status code is not any of the expected values 404 got 500
        Failed asserting that an array contains '500'.
      | 1               | 0          | 200              |
      | 2               | 0          | 404              |

data/owncloud.log does not have any entries.

"something happens" (tm) when requesting a share_id that is not numeric, and Oracle as the back-end. We get 996 or 500 error statuses rather than 404 (not found). I guess some Oracle lookup of a shares table is failing in a "bad" way that is not being caught and converted to 404.

Issue #39651

@phil-davis
Copy link
Contributor Author

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/core/34552/85/13

  Scenario: Restore a file and check, if the content and correct checksum is now in the current file                                                                                          # /drone/src/tests/acceptance/features/apiVersions/fileVersions.feature:115
    Given user "Alice" has uploaded file with content "AAAAABBBBBCCCCC" and checksum "MD5:45a72715acdd5019c5be30bdbb75233e" to "/davtest.txt"                                                 # ChecksumContext::userHasUploadedFileWithContentAndChecksumToUsingTheAPI()
    And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "/davtest.txt" with checksum "MD5:d70b40f177b14b470d1756a3c12b963a"                                                   # ChecksumContext::userHasUploadedFileToWithChecksumUsingTheAPI()
    And the version folder of file "/davtest.txt" for user "Alice" should contain "1" element                                                                                                 # FilesVersionsContext::theVersionFolderOfFileShouldContainElements()
    When user "Alice" restores version index "1" of file "/davtest.txt" using the WebDAV API                                                                                                  # FilesVersionsContext::userRestoresVersionIndexOfFile()
    Then the content of file "/davtest.txt" for user "Alice" should be "AAAAABBBBBCCCCC"                                                                                                      # FeatureContext::contentOfFileForUserShouldBe()
    And as user "Alice" the webdav checksum of "/davtest.txt" via propfind should match "SHA1:acfa6b1565f9710d4d497c6035d5c069bd35a8e8 MD5:45a72715acdd5019c5be30bdbb75233e ADLER32:1ecd03df" # ChecksumContext::theWebdavChecksumOfViaPropfindShouldMatch()

The version-restore scenario passes on Oracle nowadays. The issue #37026 has been fixed at some time. I will comment in the issue and close it.

The test refactoring will be merged to master in PR #39757

@phil-davis
Copy link
Contributor Author

all done - tests refactored and issue closed.

@phil-davis phil-davis closed this Feb 8, 2022
@phil-davis phil-davis deleted the test-with-oracle branch February 8, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant