Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Add spaces example for apiWebdavUpload1 suite #39771

Merged
merged 1 commit into from
Feb 9, 2022
Merged

[tests-only][full-ci] Add spaces example for apiWebdavUpload1 suite #39771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 88 additions & 5 deletions tests/acceptance/features/apiWebdavUpload1/uploadFile.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,19 @@ Feature: upload file
| old | /upload.txt |
| old | /नेपाली.txt |
| old | /strängé file.txt |
| old | /s,a,m,p,l,e.txt |
| new | /upload.txt |
| new | /strängé file.txt |
| new | /नेपाली.txt |
| old | /s,a,m,p,l,e.txt |
| new | /strängé file.txt |
| new | /s,a,m,p,l,e.txt |

@skipOnOcV10 @personalSpace
Examples:
| dav_version | file_name |
| spaces | /upload.txt |
| dav_version | file_name |
| spaces | /upload.txt |
| spaces | /नेपाली.txt |
| spaces | /strängé file.txt |
| spaces | /s,a,m,p,l,e.txt |


Scenario Outline: upload a file and check download content
Expand All @@ -43,6 +46,12 @@ Feature: upload file
| new | "C++ file.cpp" |
| new | "file #2.txt" |

@skipOnOcV10 @personalSpace
Examples:
| dav_version | file_name |
| spaces | "C++ file.cpp" |
| spaces | "file #2.txt" |

@issue-ocis-reva-265
#after fixing all issues delete this Scenario and merge with the one above
Scenario Outline: upload a file and check download content
Expand All @@ -58,6 +67,13 @@ Feature: upload file
| new | " ?fi=le&%#2 . txt" |
| new | " # %ab ab?=ed " |

@skipOnOcV10 @personalSpace
Examples:
| dav_version | file_name |
| spaces | "file ?2.txt" |
| spaces | " ?fi=le&%#2 . txt" |
| spaces | " # %ab ab?=ed " |


Scenario Outline: upload a file with comma in the filename and check download content
Given using <dav_version> DAV path
Expand All @@ -72,6 +88,13 @@ Feature: upload file
| new | ",,,.txt" |
| new | ",,,.," |

@skipOnOcV10 @personalSpace
Examples:
| dav_version | file_name |
| spaces | "sample,1.txt" |
| spaces | ",,,.txt" |
| spaces | ",,,.," |


Scenario Outline: upload a file into a folder and check download content
Given using <dav_version> DAV path
Expand All @@ -91,6 +114,15 @@ Feature: upload file
| new | /नेपाली | नेपाली |
| new | /folder #2.txt | file #2.txt |

@skipOnOcV10 @personalSpace
Examples:
| dav_version | folder_name | file_name |
| spaces | /strängé folder | strängé file.txt |
| spaces | /upload | abc.txt |
| spaces | /C++ folder | C++ file.cpp |
| spaces | /नेपाली | नेपाली |
| spaces | /folder #2.txt | file #2.txt |

@issue-ocis-reva-265
#after fixing all issues delete this Scenario and merge with the one above
Scenario Outline: upload a file into a folder and check download content
Expand All @@ -105,6 +137,12 @@ Feature: upload file
| new | /folder ?2.txt | file ?2.txt |
| new | /?fi=le&%#2 . txt | # %ab ab?=ed |

@skipOnOcV10 @personalSpace
Examples:
| dav_version | folder_name | file_name |
| spaces | /folder ?2.txt | file ?2.txt |
| spaces | /?fi=le&%#2 . txt | # %ab ab?=ed |

@skipOnOcV10.3 @skipOnOcV10.4 @skipOnOcV10.5
Scenario Outline: attempt to upload a file into a nonexistent folder
Given using <dav_version> DAV path
Expand All @@ -117,6 +155,11 @@ Feature: upload file
| old |
| new |

@skipOnOcV10 @personalSpace
Examples:
| dav_version |
| spaces |

@issue-ocis-reva-15
Scenario Outline: Uploading file to path with extension .part should not be possible
Given using <dav_version> DAV path
Expand All @@ -132,6 +175,11 @@ Feature: upload file
| old |
| new |

@skipOnOcV10 @personalSpace
Examples:
| dav_version |
| spaces |


Scenario Outline: upload a file into a folder with dots in the path and check download content
Given using <dav_version> DAV path
Expand All @@ -153,6 +201,15 @@ Feature: upload file
| new | /upload...1.. | abc...txt.. |
| new | /... | ... |

@skipOnOcV10 @personalSpace
Examples:
| dav_version | folder_name | file_name |
| spaces | /upload. | abc. |
| spaces | /upload. | abc . |
| spaces | /upload.1 | abc.txt |
| spaces | /upload...1.. | abc...txt.. |
| spaces | /... | ... |

@issue-ocis-reva-174
Scenario Outline: upload file with mtime
Given using <dav_version> DAV path
Expand All @@ -165,6 +222,11 @@ Feature: upload file
| old |
| new |

@skipOnOcV10 @personalSpace
Examples:
| dav_version |
| spaces |

@issue-ocis-reva-174
phil-davis marked this conversation as resolved.
Show resolved Hide resolved
Scenario Outline: upload a file with mtime in a folder
Given using <dav_version> DAV path
Expand All @@ -178,6 +240,11 @@ Feature: upload file
| old |
| new |

@skipOnOcV10 @personalSpace
Examples:
| dav_version |
| spaces |

@issue-ocis-reva-174
Scenario Outline: moving a file does not change its mtime
Given using <dav_version> DAV path
Expand All @@ -192,6 +259,11 @@ Feature: upload file
| old |
| new |

@skipOnOcV10 @personalSpace
Examples:
| dav_version |
| spaces |

@issue-ocis-reva-174
Scenario Outline: overwriting a file changes its mtime
Given using <dav_version> DAV path
Expand All @@ -205,6 +277,12 @@ Feature: upload file
| old |
| new |

@skipOnOcV10 @personalSpace
Examples:
| dav_version |
| spaces |

phil-davis marked this conversation as resolved.
Show resolved Hide resolved

Scenario Outline: upload a hidden file and check download content
Given using <dav_version> DAV path
And user "Alice" has created folder "/FOLDER"
Expand All @@ -224,4 +302,9 @@ Feature: upload file
Examples:
| dav_version |
| old |
| new |
| new |

@skipOnOcV10 @personalSpace
Examples:
| dav_version |
| spaces |
10 changes: 10 additions & 0 deletions tests/acceptance/features/apiWebdavUpload1/uploadFileToBlacklistedName.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ Feature: users cannot upload a file to a blacklisted name
| old |
| new |

@skipOnOcV10 @personalSpace
Examples:
| dav_version |
| spaces |

@skipOnOcV10.3
@issue-ocis-reva-54
Scenario Outline: upload a file to a filename that matches (or not) blacklisted_files_regex
Expand Down Expand Up @@ -65,3 +70,8 @@ Feature: users cannot upload a file to a blacklisted name
| dav_version |
| old |
| new |

@skipOnOcV10 @personalSpace
Examples:
| dav_version |
| spaces |
15 changes: 15 additions & 0 deletions tests/acceptance/features/apiWebdavUpload1/uploadFileToExcludedDirectory.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ Feature: users cannot upload a file to or into an excluded directory
| old |
| new |

@skipOnOcV10 @personalSpace
Examples:
| dav_version |
| spaces |

@issue-ocis-reva-54
Scenario Outline: upload a file to an excluded directory name inside a parent directory
Given using <dav_version> DAV path
Expand All @@ -34,6 +39,11 @@ Feature: users cannot upload a file to or into an excluded directory
| old |
| new |

@skipOnOcV10 @personalSpace
Examples:
| dav_version |
| spaces |

@skipOnOcV10.3
@issue-ocis-reva-54
Scenario Outline: upload a file to a filename that matches (or not) excluded_directories_regex
Expand Down Expand Up @@ -70,3 +80,8 @@ Feature: users cannot upload a file to or into an excluded directory
| dav_version |
| old |
| new |

@skipOnOcV10 @personalSpace
Examples:
| dav_version |
| spaces |
3 changes: 2 additions & 1 deletion tests/acceptance/features/bootstrap/WebDav.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2922,7 +2922,8 @@ public function userUploadsFileToWithMtimeUsingTheWebdavApi(
$this->acceptanceTestsDirLocation() . $source,
$destination,
$this->getStepLineRef(),
["X-OC-Mtime" => $mtime]
["X-OC-Mtime" => $mtime],
$this->getDavPathVersion()
);
}

Expand Down