Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] [WIP] More flexible tests for share ids #40095

Closed
wants to merge 19 commits into from
Closed

[tests-only] [full-ci] [WIP] More flexible tests for share ids #40095

wants to merge 19 commits into from

Conversation

phil-davis
Copy link
Contributor

Description

wip

Related Issue

#40093

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this May 23, 2022
phil-davis
phil-davis commented May 24, 2022
View reviewed changes
tests/acceptance/features/apiShareCreateSpecialToRoot1/createShareExpirationDate.feature
When the public accesses the preview of file "textfile0.txt" from the last shared public link using the sharing API
Then the HTTP status code should be "404"
And user "Alice" should not see the share id of the last share
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bit of an unneeded step, IMO. We already know that the share cannot be accessed.
If someone thinks it is needed, then I could implement a step:

And user "Alice" should not see the share id of the last public link share

@phil-davis phil-davis mentioned this pull request May 24, 2022
Closed
@phil-davis phil-davis force-pushed the issue-40093 branch 2 times, most recently from 9e20b7c to 90a7ad3 Compare May 27, 2022 05:17
This was referenced May 27, 2022
Closed
Closed
@phil-davis phil-davis mentioned this pull request May 30, 2022
Closed
@phil-davis phil-davis mentioned this pull request May 30, 2022
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

see #40114 for the squashed version of this, for review.

@phil-davis
Copy link
Contributor Author

code was merged in #40114

@phil-davis phil-davis closed this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@phil-davis phil-davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@phil-davis