-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] remove 'Shares' folder including tests examples for Spaces DAV from apiShareOperationsToShares1
#40302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
76fd2ac
to
0d292b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
@@ -9,7 +9,7 @@ Feature: sharing | |||
| Alice | | |||
| Brian | | |||
|
|||
@smokeTest | |||
@smokeTest @notToImplementOnOCIS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kiranparajuli589 please remind me - why will this not work on oCIS for Brian to move a file of his into the shared folder received from Alice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phil-davis there's issue regarding it owncloud/ocis#764. And also for spaces
owncloud/ocis#4087 (comment) we cannot move resource between spaces. And the response status is 502
for all webdav as per this comment owncloud/ocis#4087 (comment). Maybe it will not be implemented i guess or ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a scenario describing this feature in oCIS. https://github.com/owncloud/ocis/blob/d1f0dbc4c928539fe0a97af8aeb224f5fafb8d22/tests/acceptance/features/apiSpaces/moveSpaces.feature#L113
I think this was a feature so mentioned that @notToImplementOnOCIS
tag here. We only can create|upload file inside the Shares Jail but cannot move into|out from it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the last discussion, we let this type of moving-in to sharing folder to run and add to the expected failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have closed the issue related to moving files out of Shares owncloud/ocis#2141
According to this issue, actual behavior is we can't move resources out of Shares.
In case of moving resources inside Share, this issue is opened
owncloud/ocis#764
…es DAV Signed-off-by: Kiran Parajuli <[email protected]>
0d292b8
to
188d34c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…loud/core#40302 Signed-off-by: Kiran Parajuli <[email protected]>
Description
Removed tests examples involving interactions within
Shares
folder and spaces WebDAV from suiteapiShareOperationsToShares1
Related Issue
/Shares
folder with spaces DAV version ocis#4154How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by: Kiran Parajuli [email protected]