Update bare metal deployments #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jnweiger
reviewed
Nov 19, 2024
jnweiger
reviewed
Nov 19, 2024
Co-authored-by: Jürgen Weigert <[email protected]>
jnweiger
reviewed
Nov 19, 2024
jnweiger
reviewed
Nov 19, 2024
jnweiger
reviewed
Nov 19, 2024
jnweiger
reviewed
Nov 19, 2024
jnweiger
reviewed
Nov 19, 2024
jnweiger
reviewed
Nov 19, 2024
jnweiger
suggested changes
Nov 19, 2024
There was a problem hiding this comment.
thanks for the much cleaner killall.
But confusing the terms source and binary now is a bad idea imo.
In the scope of discussing the parameters of a symbolic link, one often refers to then as source and target, but the change of scope is surprising here.
Source is more likely associated with source code that needs to be compiled in this context.
Co-authored-by: Jürgen Weigert <[email protected]>
jnweiger
reviewed
Nov 20, 2024
Co-authored-by: Jürgen Weigert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1052 ([QA] Upgrade procedure fails to shut down ocis when using systemd)
References: #1029 (review)
This PR fixes:
killallinstead ofkillfor shutting down minimal bare metal(not bare metal, this uses systemd)
Backport to 5.0