Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version output #469

Merged
merged 2 commits into from
Apr 24, 2023
Merged

fix version output #469

merged 2 commits into from
Apr 24, 2023

Conversation

individual-it
Copy link
Member

adjust the output of the version command to the reality

@individual-it individual-it requested a review from mmattel April 24, 2023 10:33
@mmattel
Copy link
Contributor

mmattel commented Apr 24, 2023

I will make compiledalso an attribute like the version which eases maintenance

@individual-it
Copy link
Member Author

we would have to update it every day ;-) owncloud/ocis#6124

@mmattel
Copy link
Contributor

mmattel commented Apr 24, 2023

we would have to update it every day ;-) owncloud/ocis#6124

Not correct, because {ocis-stable} resolves to 2.0.0
Both attributes will get updated only when a new stable release gets published.
It has nothing to do with daily builds.

@mmattel
Copy link
Contributor

mmattel commented Apr 24, 2023

Note that the attributes (variables) here in the ocis repo are "local" and will only have relevance when doing a local build. For the web, the attribute is defined equaly in the docs repo as this repo will include all repos and makes the final complete build. I have updated the docs repo just now so we can merge this easily and building will be fine.

@mmattel
Copy link
Contributor

mmattel commented Apr 24, 2023

Here is a screenshot of the rendered version:
image

@mmattel mmattel merged commit 2a2d0c8 into master Apr 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the version-output branch April 24, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants