Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configuration for search extractor #142

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jan 27, 2023

Description

exposes a configuration option to use the tika search extractor

Related Issue

Motivation and Context

How Has This Been Tested?

  • run with Tika in Minikube

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

@wkloucek wkloucek force-pushed the tika-search-extractor branch from 19ff9d6 to 7a65f29 Compare February 13, 2023 10:24
@wkloucek wkloucek marked this pull request as ready for review February 23, 2023 13:17
@wkloucek wkloucek force-pushed the tika-search-extractor branch from 7a65f29 to 346e987 Compare March 9, 2023 07:55
@wkloucek wkloucek requested review from kobergj and rhafer March 9, 2023 07:57
@wkloucek wkloucek requested a review from d7oc March 20, 2023 09:18
@wkloucek
Copy link
Contributor Author

Can be tested with Tika, this is my helmfile to deploy tika:

repositories:
  - name: tika
    url: https://apache.jfrog.io/artifactory/tika

releases:
  - name: tika
    namespace: tika
    chart: tika/tika
    version: 2.2.1

Copy link
Contributor

@d7oc d7oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One remark added below.

charts/ocis/values.yaml Show resolved Hide resolved
@wkloucek wkloucek merged commit c07dc30 into master Mar 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the tika-search-extractor branch March 20, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants