Skip to content

Commit

Permalink
fix(ocis-pkg/service): remove gobreaker lib
Browse files Browse the repository at this point in the history
Signed-off-by: jkoberg <[email protected]>
  • Loading branch information
kobergj committed Nov 8, 2024
1 parent 5acd24d commit 432aea3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 5 additions & 0 deletions changelog/unreleased/remove-mbreaker.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Enhancement: Remove mbreaker

The circuit breaker is not handle correctly and leads therefore to more issues than it solves. We removed it.

https://github.com/owncloud/ocis/pull/10524
2 changes: 0 additions & 2 deletions ocis-pkg/service/grpc/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"os"

mgrpcc "github.com/go-micro/plugins/v4/client/grpc"
mbreaker "github.com/go-micro/plugins/v4/wrapper/breaker/gobreaker"
mtracer "github.com/go-micro/plugins/v4/wrapper/trace/opentelemetry"
"github.com/owncloud/ocis/v2/ocis-pkg/registry"
"github.com/owncloud/ocis/v2/ocis-pkg/shared"
Expand Down Expand Up @@ -69,7 +68,6 @@ func NewClient(opts ...ClientOption) (client.Client, error) {
var tlsConfig *tls.Config
cOpts := []client.Option{
client.Registry(reg),
client.Wrap(mbreaker.NewClientWrapper()),
client.Wrap(mtracer.NewClientWrapper(
mtracer.WithTraceProvider(options.tp),
)),
Expand Down

0 comments on commit 432aea3

Please sign in to comment.