Merge pull request #2109 from owncloud/fix-groups-index

fix: make groups index case sensitive
owncloud · Jun 1, 2021 · 99b517a · 99b517a
2 parents 06da18c + 03aa641
commit 99b517a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/accounts/pkg/service/v0/index.go b/accounts/pkg/service/v0/index.go
@@ -63,11 +63,11 @@ func recreateContainers(idx *indexer.Indexer, cfg *config.Config) error {
 	}
 
 	// Groups
-	if err := idx.AddIndex(&proto.Group{}, "OnPremisesSamAccountName", "Id", "groups", "unique", nil, true); err != nil {
+	if err := idx.AddIndex(&proto.Group{}, "OnPremisesSamAccountName", "Id", "groups", "unique", nil, false); err != nil {
 		return err
 	}
 
-	if err := idx.AddIndex(&proto.Group{}, "DisplayName", "Id", "groups", "non_unique", nil, true); err != nil {
+	if err := idx.AddIndex(&proto.Group{}, "DisplayName", "Id", "groups", "non_unique", nil, false); err != nil {
 		return err
 	}
 

diff --git a/changelog/unreleased/fix-groups-index.md b/changelog/unreleased/fix-groups-index.md
@@ -0,0 +1,5 @@
+Bugfix: Change the groups index to be case sensitive 
+
+Groups are considered to be case sensitive. The index must handle them case sensitive too otherwise we will have undeterministic behavior while editing or deleting groups.
+
+https://github.com/owncloud/ocis/pull/2109