Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading with old-chunking does not work #1343

Closed
individual-it opened this issue Jan 21, 2020 · 13 comments
Closed

Uploading with old-chunking does not work #1343

individual-it opened this issue Jan 21, 2020 · 13 comments
Labels
Category:Defect Existing functionality is not working as expected Type:Bug

Comments

@individual-it
Copy link
Member

trying to upload the file does not show any issues, but the result cannot be listed

$ curl --user user0:123456 http://localhost:9140/remote.php/webdav/home/file-chunking-1234-2-0 --request PUT -d"AAA" -H "OC-Chunked:1"
$ curl --user user0:123456 http://localhost:9140/remote.php/webdav/home/file-chunking-1234-2-1 --request PUT -d"BBB" -H "OC-Chunked:1"
$ curl --user user0:123456 http://localhost:9140/remote.php/webdav/home --request PROPFIND | xmllint --format -
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   854  100   854    0     0  50235      0 --:--:-- --:--:-- --:--:-- 50235
<?xml version="1.0" encoding="utf-8"?>
<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:oc="http://owncloud.org/ns">
  <d:response>
    <d:href>/remote.php/webdav/home/</d:href>
    <d:propstat>
      <d:prop>
        <oc:id>MTIzZTQ1NjctZTg5Yi0xMmQzLWE0NTYtNDI2NjU1NDQwMDAwOmVjNzMwZGI3LTEyNjYtNDUwNC1iODYwLWQzMzNkMTliNTMxNw==</oc:id>
        <oc:fileid>MTIzZTQ1NjctZTg5Yi0xMmQzLWE0NTYtNDI2NjU1NDQwMDAwOmVjNzMwZGI3LTEyNjYtNDUwNC1iODYwLWQzMzNkMTliNTMxNw==</oc:fileid>
        <d:getetag>"d37e5cdffff691d3d6701109d75df380"</d:getetag>
        <oc:permissions>WCKDNVR</oc:permissions>
        <d:resourcetype>
          <d:collection/>
        </d:resourcetype>
        <d:getcontenttype>httpd/unix-directory</d:getcontenttype>
        <oc:size>4096</oc:size>
        <d:getlastmodified>Tue, 21 Jan 2020 07:52:05 UTC</d:getlastmodified>
        <oc:favorite>0</oc:favorite>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
  </d:response>
</d:multistatus>

@PVince81
Copy link
Contributor

related: #195

@butonic butonic transferred this issue from owncloud/ocis-reva Jan 18, 2021
@refs refs changed the title uploading with old-chunking does not work Uploading with old-chunking does not work Jan 19, 2021
@refs refs added the Category:Defect Existing functionality is not working as expected label Jan 19, 2021
@settings settings bot removed the p3-medium label Apr 7, 2021
@stale
Copy link

stale bot commented Jun 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Jun 6, 2021
@stale stale bot closed this as completed Jun 16, 2021
@stale stale bot removed the Status:Stale label Jun 18, 2021
@dpakach
Copy link
Contributor

dpakach commented Jul 1, 2021

@butonic @refs will the chunking upload ever be implemented in ocis? If not we can remove the tests that are currently being run(but fails) for the chunking upload.

@refs
Copy link
Member

refs commented Jul 1, 2021

Hi @dpakach !

It depends on the backend - decomposedfs uses tus by default, but I know by a fact that EOS uses the old chunking and not tus. My gut feeling tells me to remove the tests for the current decomposedfs because we use tus, but perhaps @pmaier1 or @micbar can bring more to the table.

@dpakach
Copy link
Contributor

dpakach commented Aug 3, 2021

Since there has not been any updates here, I will skip those tests as we dont run tests with EOS here. We can reenable them in the future if it is required.

@phil-davis
Copy link
Contributor

Note: "old" v1 chunking is supported on reva and OCIS. Many of the scenarios are now passing. So we do want to keep running chunking v1 test scenarios in reva and oCIS.

@stale
Copy link

stale bot commented Oct 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Dec 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Dec 4, 2021
@stale stale bot closed this as completed Dec 14, 2021
@SwikritiT
Copy link
Contributor

there are tests linked to this issue

#### [uploading with old-chunking does not work](https://github.com/owncloud/ocis/issues/1343)
- [apiWebdavUpload1/uploadFileToExcludedDirectory.feature:20](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavUpload1/uploadFileToExcludedDirectory.feature#L20)
- [apiWebdavUpload1/uploadFileToExcludedDirectory.feature:21](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavUpload1/uploadFileToExcludedDirectory.feature#L21)
- [apiWebdavUpload1/uploadFileToExcludedDirectory.feature:26](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavUpload1/uploadFileToExcludedDirectory.feature#L26)
- [apiWebdavUpload1/uploadFileToExcludedDirectory.feature:39](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavUpload1/uploadFileToExcludedDirectory.feature#L39)
- [apiWebdavUpload1/uploadFileToExcludedDirectory.feature:40](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavUpload1/uploadFileToExcludedDirectory.feature#L40)
- [apiWebdavUpload1/uploadFileToExcludedDirectory.feature:45](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavUpload1/uploadFileToExcludedDirectory.feature#L45)
- [apiWebdavUpload1/uploadFileToExcludedDirectory.feature:81](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavUpload1/uploadFileToExcludedDirectory.feature#L81)
- [apiWebdavUpload1/uploadFileToExcludedDirectory.feature:82](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavUpload1/uploadFileToExcludedDirectory.feature#L82)
- [apiWebdavUpload1/uploadFileToExcludedDirectory.feature:87](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavUpload1/uploadFileToExcludedDirectory.feature#L87)

@SwikritiT SwikritiT reopened this May 25, 2022
@stale stale bot removed the Status:Stale label May 25, 2022
@ScharfViktor
Copy link
Contributor

we didn't move tests apiWebdavUpload1/uploadFileToExcludedDirectory to ocis and we have now no tests in the expected failures and

@SwikritiT
Copy link
Contributor

we didn't move tests apiWebdavUpload1/uploadFileToExcludedDirectory to ocis and we have now no tests in the expected failures and

Why didn't we move them are they not relevant for the current ocis?

@SwikritiT
Copy link
Contributor

SwikritiT commented Apr 5, 2023

we didn't move tests apiWebdavUpload1/uploadFileToExcludedDirectory to ocis and we have now no tests in the expected failures and

Why didn't we move them are they not relevant for the current ocis?

https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavUpload1/uploadFileToExcludedDirectory.feature
They used occ commands to do certain operation so probably because of that?
But is this issue still relevant for ocis? or not?

@micbar
Copy link
Contributor

micbar commented May 28, 2024

Not relevant for ocis anymore.

@micbar micbar closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Defect Existing functionality is not working as expected Type:Bug
Projects
None yet
Development

No branches or pull requests

9 participants