Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] skip old chunking tests on ocis #39089

Closed
wants to merge 1 commit into from

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Aug 3, 2021

Description

[tests-only] skip old chunking tests on ocis
owncloud/ocis#1343 (comment)

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIComments-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31725/131/1

Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor

@dpakach in PR #39051 I skipped the new chunking tests on OCIS.

I thought that the "old" chunking is supposed to be the chunking that is being supported on OCIS.

Now I am confused. What chunking is supposed to be implemented for OCIS?

@dpakach
Copy link
Contributor Author

dpakach commented Aug 4, 2021

@phil-davis as far as I know, ocis doesn't support chunking as it uses TUS except for EOS storage. But since we dont run tests with EOS, I suppose we can remove this.
owncloud/ocis#1343 (comment)

@phil-davis
Copy link
Contributor

There has been discussion in the OCIS chat. I will clarify at the standup today.

@dpakach
Copy link
Contributor Author

dpakach commented Aug 5, 2021

not required since ocis will support chunking v1

@dpakach dpakach closed this Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants