Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on Favorites throws Loading folder failed… #354

Closed
ChrisEdS opened this issue Jul 1, 2020 · 3 comments
Closed

Clicking on Favorites throws Loading folder failed… #354

ChrisEdS opened this issue Jul 1, 2020 · 3 comments
Assignees

Comments

@ChrisEdS
Copy link
Contributor

ChrisEdS commented Jul 1, 2020

I just tested the current beta on ocis-latest.owncloud.com.

When clicking on Favorites I get an Unknown error.

image

@ChrisEdS ChrisEdS changed the title Clicking on Favorites throws Loading folder failed… Clicking on Favorites throws Loading folder failed… Jul 1, 2020
@micbar micbar added bug labels Jul 1, 2020
@PVince81
Copy link
Contributor

PVince81 commented Jul 9, 2020

I think favorites are not supported yet in OCIS.

Ideally we should make a capability out of it and then disable it from the UI when not supported.
It might happen that some storage doesn't support extended metadata so tagging a file as favorite there would not work.

On the other hand, it feels weird to rely on storage capabilities for something like a favorite. Maybe we should store that information elsewhere, in some "ocis-favorites" service that is storage independent.

The capability approach would require adding some values in OC 10 as well to have the favorite visible again when used with ocis-web.

@PVince81
Copy link
Contributor

PVince81 commented Jul 9, 2020

I've raised https://github.com/owncloud/ocis-reva/issues/361 for finishing the favorites implementation eventually.

For the scope of this ticket:

This would remove the feature from the UI until it is properly implemented.

@LukasHirt
Copy link
Collaborator

@PVince81 Let's close this ticket? ocis-web PR got merged as well

refs pushed a commit that referenced this issue Sep 18, 2020
[Tests-Only] Use latest osixia/openldap in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants