-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA] OCIS: Error while trying to log in to OAuth2-enabled server. #6415
Comments
Ocis bare metal server setup with apache reverse proxy and internal IDP; according to https://github.com/owncloud/QA/blob/master/tools/hetzner-deploy/deploy_ocis_bare_metal.sh DCR seems to be off in this server, is this a problem? |
No. This seems to be related to a recent change we did to the internal IDP's configuration. (52951b4). For some reason the |
So after a bit of debugging it seems that lico does not apply the configured Meanwhile, with the 3.0 release in mind, it's probably best if we revert 52951b4 for now even if that partially brings us #904 back. |
This reverts commit 52951b4. The change broke authentication for at least the desktop client when using the builtin idp. There seem to be issues in the IDP (lico) which result in the implicit scoped not being added correctly in some case. When that scope is missing the `lg.uuid` claim will not be present in the userinfo and we can correctly match users by id. This reverts back to the old behaviour of matching users by name. Which also brings some aspects of owncloud#904 Fixes owncloud#6415
This reverts commit 52951b4. The change broke authentication for at least the desktop client when using the builtin idp. There seem to be issues in the IDP (lico) which result in the implicit scoped not being added correctly in some case. When that scope is missing the `lg.uuid` claim will not be present in the userinfo and we can correctly match users by id. This reverts back to the old behaviour of matching users by name. Which also brings some aspects of owncloud#904 Fixes owncloud#6415
This reverts commit 52951b4. The change broke authentication for at least the desktop client when using the builtin idp. There seem to be issues in the IDP (lico) which result in the implicit scoped not being added correctly in some case. When that scope is missing the `lg.uuid` claim will not be present in the userinfo and we can correctly match users by id. This reverts back to the old behaviour of matching users by name. Which also brings some aspects of #904 Fixes #6415
This reverts commit 52951b4. The change broke authentication for at least the desktop client when using the builtin idp. There seem to be issues in the IDP (lico) which result in the implicit scoped not being added correctly in some case. When that scope is missing the `lg.uuid` claim will not be present in the userinfo and we can correctly match users by id. This reverts back to the old behaviour of matching users by name. Which also brings some aspects of #904 Fixes #6415
Workaround(Without having the revert e012901) PROXY_USER_OIDC_CLAIM=preferred_username Now desktop client 4.1.0 can connect. |
Upstream bug report: libregraph/lico#98 |
Confirmed fixed in today's https://download.owncloud.com/ocis/ocis/daily/ocis-testing-linux-amd64 |
This reverts commit 52951b4. The change broke authentication for at least the desktop client when using the builtin idp. There seem to be issues in the IDP (lico) which result in the implicit scoped not being added correctly in some case. When that scope is missing the `lg.uuid` claim will not be present in the userinfo and we can correctly match users by id. This reverts back to the old behaviour of matching users by name. Which also brings some aspects of #904 Fixes #6415
Pre-submission Checks
Describe the bug
Download
https://download.owncloud.com/desktop/ownCloud/daily/3.2/linux-appimage/ownCloud-3.2.2.10628-daily20230413-x86_64.AppImage
https://download.owncloud.com/desktop/ownCloud/daily/4.0/linux-appimage/ownCloud-4.0.0.10900-daily20230512-x86_64.AppImage
https://download.owncloud.com/desktop/ownCloud/daily/4.1/linux-appimage/ownCloud-4.1.0.11119-daily20230531-x86_64.AppImage
Paste the https url of an ocis instance.
The client redirects to a web browser.
Log in through the web browser, by pasting admin username and admin password, and granting access.
The login at the browser succeeds, but the desktop client has an error.
The ocis server log shows
The client log fro 3.2 ends with:
The client log from 4.0 ends with:
The client log from 4.1 end with:
Expected behavior
Client can connect.
Steps to reproduce the issue
No response
Screenshots
.
Logs
.
Client version number
Same with all three versions 3.2.2, 4.0.0, 4.1.0 from the URLs above.
Desktop environment (Linux only)
ubintu 20.04
Client package version and origin (Linux only)
No response
Installation path (Windows only)
No response
Server information
ocis version
Version: 3.0.0-rc.4+971ba4e76
Compiled: 2023-05-23 00:00:00 +0000
Additional context
No response
The text was updated successfully, but these errors were encountered: