[search] No response from server while searching inside a folder containing space in name

[grgprarup]

Describe the bug

The server response is empty when the file is searched inside a current folder if the parent folder name has whitespace character in it.

Steps to reproduce

Steps to reproduce the behavior:

1. As user einstein, Create a folder New Folder
2. Create a file file1.txt in the root and inside of New Folder
3. Search for the keyword file from inside the New Folder

Expected behavior

Must return a list of files.

Actual behavior

Payload

<?xml version="1.0"?>
<oc:search-files  xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns">
  <d:prop>
    <oc:permissions />
    <oc:favorite />
    <oc:fileid />
    <oc:file-parent />
    <oc:name />
    <oc:owner-id />
    <oc:owner-display-name />
    <oc:shareid />
    <oc:shareroot />
    <oc:share-types />
    <oc:privatelink />
    <d:getcontentlength />
    <oc:size />
    <d:getlastmodified />
    <d:getetag />
    <d:getcontenttype />
    <d:resourcetype />
    <oc:downloadURL />
    <oc:tags />
  </d:prop>
  <oc:search>
    <oc:pattern>file scope:f42859af-f142-4691-97e2-9ba377d61acd$4c510ada-c86b-4815-8820-42cdf82c3d51/New folder</oc:pattern>
    <oc:limit>8</oc:limit>
  </oc:search>
</oc:search-files>

Response

<d:multistatus xmlns:s="http://sabredav.org/ns" xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns"></d:multistatus>

Setup

Please describe how you started the server and provide a list of relevant environment variables or configuration files.

OCIS_version= 3.1.0-rc.1, 4.0.0-rc.1

[individual-it]

@grgprarup is the problem if the name contains the string "space" or if the name contains a space character " "?

[grgprarup]

@grgprarup is the problem if the name contains the string "space" or if the name contains a space character " "?

its the space character " ", e.g. New Folder, Sample Folder

[hodyroff]

It seems that when I switch to "all folders" it works. Therefor easy workaround, not a blocker.
To be fixed ASAP.

[fschade]

<oc:pattern>aa scope:44df7993-16c0-4159-a6de-6f5aacb4dc50$9959421d-a0e9-4013-bbb8-7f0f539923b7/Neuer Ordner</oc:pattern>

scope looks fishy to me, i have a look

[fschade]

cc: @2403905 looks like a scope issue, should I check or do you take over

[fschade]

its the whitespace character:

Entry("When scope contains whitespace",
  `scope:<uuid>/new folder/subfolder file`,
  `file`,
  `<uuid>/new folder/subfolder`,
),

regex: scope:\s*([^" "\n\r]*)

it cannot handle the whitespace... which is hard.... how to detect if file is part of the path or a dedicated query token on its own.... let us discuss this in zoom

[dj4oC]

IMHO annoying bug but no release blocker

[fschade]

will be fixed in the next release, i take this as a test item for the kql story, we have to quote it!

[fschade]

✅ for the kql version: 5dc8d3f

[grgprarup]

Test Coverage:

• Add examples in the test for these case [tests-only][full-ci]Add tests for searching for resources with whitespace chars in its name #7619
• Check for other cases as well

[2403905]

cc: @2403905 looks like a scope issue, should I check or do you take over

I'll take the issue. I'm not sure that kql will help solve the problem because we have to use the scope before we call the search API and parse the query string to kql ast.
@fschade FYI

[2403905]

@janackermann Can we wrap the scope value in the double quotes and escape the quote characters in the middle of the path like the \" or ""?
scope:"<uuid>/folder/sub folder/book \"Bob's stories\"" or scope:"<uuid>/folder/sub folder/book ""Bob's stories"""

[ScharfViktor]

I guess the issue can be closed.

using resourceID in scope solved issue

before: <oc:pattern>file scope:f42859af-f142-4691-97e2-9ba377d61acd$4c510ada-c86b-4815-8820-42cdf82c3d51/New folder</oc:pattern>

now: <oc:pattern>name:&quot;*file*&quot; scope:e49de8ab-e3c5-43dc-b83e-6337e680ae7c$96a25d9d-e174-4af1-90d1-e94c8a165401!9a1c05ac-0956-4592-86db-79d8ae311010</oc:pattern>