-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] enhancement: add support for natural language kql date ranges #7263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Restriction queries
connecting nodes (with edges) seem straight forward when not using group, the default connection for nodes with the same node is always OR. THis only applies for first level nodes, for grouped nodes it is defined differently. The KQL docs are saying, nodes inside a grouped node, with the same key are connected by a AND edge.
…s with leading binary operator
fschade
force-pushed
the
human-date-time-tokens
branch
from
September 11, 2023 14:36
859045b
to
9ac725c
Compare
fschade
force-pushed
the
human-date-time-tokens
branch
from
September 15, 2023 07:31
01399ac
to
6eea049
Compare
Kudos, SonarCloud Quality Gate passed! |
kobergj
requested changes
Sep 15, 2023
2403905
approved these changes
Sep 15, 2023
fschade
commented
Sep 15, 2023
kobergj
approved these changes
Sep 15, 2023
ownclouders
pushed a commit
that referenced
this pull request
Sep 15, 2023
…es (#7263) * enhancement: add more kql spec tests and simplify ast normalization * enhancement: kql parser error if query starts with AND * enhancement: add kql docs and support for date and time only dateTimeRestriction queries * enhancement: add the ability to decide how kql nodes get connected connecting nodes (with edges) seem straight forward when not using group, the default connection for nodes with the same node is always OR. THis only applies for first level nodes, for grouped nodes it is defined differently. The KQL docs are saying, nodes inside a grouped node, with the same key are connected by a AND edge. * enhancement: explicit error handling for falsy group nodes and queries with leading binary operator * enhancement: use optimized grammar for kql parser and toolify pigeon * enhancement: simplify error handling * fix: kql implicit 'AND' and 'OR' follows the ms html spec instead of the pdf spec * enhancement: add support for natural language kql date queries * enhancement: structure kql parser tests into logical clusters * fix: time-range error naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
follow up pr for the ocis kql integration, as the spec describes kql is able to select date ranges by writing natural language.
The following ranges are described in the spec and therefor supported by the ocis implementation:
Mtime:today
- range: start of today till end of todayMtime:yesterday
- range: start of yesterday till end of yesterdayMtime:"this week"
- range: start of this week till end of this weekMtime:"this month"
- range: start of this month till end of this monthMtime:"last month"
- range: start of last month till end of last monthMtime:"this year"
- range: start of this year till end of this yearMtime:"last year"
- range: start of last year till end of last yearthe ast will extended as follow:
and so on....
following queries are now exactly covered as described in the spec:
beside that it also includes:
Related Issue
Motivation and Context
implement the spec
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: