Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Preview #7127

Open
ThesiiNCey opened this issue Aug 26, 2023 · 27 comments
Open

Video Preview #7127

ThesiiNCey opened this issue Aug 26, 2023 · 27 comments
Labels
Category:Enhancement Add new functionality

Comments

@ThesiiNCey
Copy link

ThesiiNCey commented Aug 26, 2023

Is your feature request related to a problem? Please describe.

When I upload videos in the following format ( MP4 | MOV | AVI | WMV | 3GP ) I get no preview so a Thumbnail

Describe the solution you'd like

A possibility that one can use ffmpeg for this would be a great solution

@rhafer rhafer added the Category:Enhancement Add new functionality label Aug 28, 2023
@impalax33
Copy link

This feature would be really great yes

@micbar
Copy link
Contributor

micbar commented Oct 5, 2023

@ThesiiNCey

Do you know a library which does the video processing on the server side? maybe even without any C-Bindings?

@ThesiiNCey
Copy link
Author

Only ffmpeg or Imagemagic as bin only File

@micbar
Copy link
Contributor

micbar commented Oct 5, 2023

Only ffmpeg or Imagemagic as bin only File

Hm. That is what i feared. This would introduce C dependencies into our codebase, which is error prone and hard to maintain.

@ThesiiNCey
Copy link
Author

Only ffmpeg or Imagemagic as bin only File

Hm. That is what i feared. This would introduce C dependencies into our codebase, which is error prone and hard to maintain.

someone tells me it can be possible with -> https://github.com/notedit/media-server-go

@micbar
Copy link
Contributor

micbar commented Feb 17, 2024

Media Server Go has a c dependency too 🙈

@ThesiiNCey
Copy link
Author

https://github.com/h2non/imaginary

That would actually be the last method I could think of, I even asked Chatgpt for it

@micbar
Copy link
Contributor

micbar commented Feb 22, 2024

That looks very interesting.

@ThesiiNCey
Copy link
Author

so could that possibly be a possibility?

@illode
Copy link

illode commented Mar 11, 2024

Is imaginary's dependency on libvips (plus optionally libheif (and libjxl in the next release)) better than any of the other options? On top of that, the only new formats would be PDF, SVG, HEIF, AVIF, and JXL, none of which are video formats (although I would love for them to be added!)

@illode
Copy link

illode commented Mar 11, 2024

I think if generating thumbnails for a variety of video / (more) image formats is to be added, some sort of ffmpeg wrapper is pretty much unavoidable.

It looks like imaginary (built using bimg) / libvips can support more than just the formats I mentioned, but they use ImageMagick. Since ImageMagick itself doesn't support videos, when generating thumbnails from a video, it ends up just using ffmpeg anyways.

imaginary also only seems useful if the pre-built microservice itself is desired, otherwise bimg can be used directly. And while libvips' design / features do seem nice, the lack of direct video support means another dependency would be needed for video anyways, which was the whole point of this issue.

Having said all that, I would also greatly appreciate video / (more) image thumbnails. Having no thumbnails makes storing videos in OCIS somewhat unpleasant.

@ThesiiNCey
Copy link
Author

I haven't looked at it for a long time, but is it now possible to get a video preview just like with GIF and webm and webp files?

@kulmann
Copy link
Contributor

kulmann commented Jul 19, 2024

I haven't looked at it for a long time, but is it now possible to get a video preview just like with GIF and webm and webp files?

No. Sadly pretty much nothing changed in that regard :-(

@helmut72
Copy link

Isn't this now possible with libvips support?

#10310

@rhafer
Copy link
Contributor

rhafer commented Oct 23, 2024

I don't think github.com/davidbyttow/govips/v2/ can handle videos. (I don't even think libvips itself does)

@helmut72
Copy link

Thank you. I've searched for h265 and thought, h265 is always video:
https://github.com/libvips/libvips/issues?q=is%3Aissue+h265+is%3Aclosed

@vegaz337
Copy link

vegaz337 commented Nov 11, 2024

How about MoviePy,FFmpeg-python, ffmpeg.wasm, JCodec? Would love to see some progress here since its really unpleasant to have a lot of videos in the cloud

@micbar
Copy link
Contributor

micbar commented Nov 12, 2024

@vegaz337
You are welcome to contribute.

IMHO from a product perspective, that feature is not a no brainer.

Infinite Scale is a product to do "Secure File Sync and Share", enhanced by WebOffice capabilities.

Thumbnails for videos is debatable in that scope.

  1. The added value of a small random thumbnail which only represents a second from the video is not high
  2. The added resource use on the server is not proportional to the added value

From my product owner POV, I do not support that feature.

@kobergj @unbekanntes-pferd FYI

@helmut72
Copy link

added value of a small random thumbnail which only represents a second from the video is not high

IMHO better than a placeholder symbol with filename IMG_1234.MOV. No one have any clue about the content.

Infinite Scale is a product to do "Secure File Sync and Share", enhanced by WebOffice capabilities.

I thought Infinite Scale is also there for media files and not office files only? See this news from you:
https://owncloud.com/news/safe-memories/

Taking videos on any event or vacation is very common and let's imagine a lot of placeholder symbols because it's videos or heic images taken from an iPhone with default setting.

For movie files, there is even a Coverart tag possible, using an integrated image as a thumbnail.
https://superuser.com/a/1328212

@micbar
Copy link
Contributor

micbar commented Nov 14, 2024

heic images taken from an iPhone with default setting.

This is planned. See #7001

@kulmann
Copy link
Contributor

kulmann commented Nov 15, 2024

I thought Infinite Scale is also there for media files and not office files only?

I share this opinion. Office files is the thing that is investigated and implemented best at the moment - I'm sure that's what @micbar meant.

Our idea was and is, that oCIS is also a metadata platform. As such we aim to extract metadata from files (locally of course!) and make it available in a nice ui. That's also what our web extension system aims at.

Examples:

  • right sidebar Photo metadata panel, which displays some commonly used EXIF data of photos. Those are extracted via apache tika and stored in the metadata of the respective file.
  • right sidebar Audio metadata panel, which displays some commonly used id3-tags of audio files. Those are also extracted via apache tika and stored in the metadata of the respective file.
  • if an mp3 file has a cover images (back and front) they are automatically displayed as preview
  • there is a third party app https://github.com/dschmidt/web-app-gpx-viewer which not only offers an open street map integration for .gpx files, but also uses geolocation metadata (again: extracted via apache tika and stored in the metadata of the respective file) to show a small map in the right sidebar for images with geolocation info, as well as this PR feat: implement FolderView extension dschmidt/web-app-gpx-viewer#15 which aims at providing a folder view (as sibling of the list and tiles views in the files app) where files with geolocation info inside a folder a visualized as markers on a map.

Ideas I personally had in mind - but didn't have the time, yet, to follow:

  • make stored metadata available via search. E.g. Show me all photos which were taken with an aperture in the range of x-y
  • backend side transcoding of videos into h264, make those available for playback in the preview app.

As you can see, there are things going on which are not driven by office file integrations. ;-) And most importantly: You are invited to help at any time. We're building our web extension system with the idea in mind, that anyone who is interested can develop their own apps and extensions. See e.g. https://owncloud.dev/clients/web/extension-system/ for a starting point. Contributions to the main repos are of course welcome as well.

@helmut72
Copy link

I thought Infinite Scale is also there for media files and not office files only?

I share this opinion. Office files is the thing that is investigated and implemented best at the moment - I'm sure that's what @micbar meant.

In #7127 (comment) he wrote: "I do not support that feature.". No

IMHO no room for other interpretations.

@vegaz337
Copy link

vegaz337 commented Nov 16, 2024

@vegaz337 You are welcome to contribute.

IMHO from a product perspective, that feature is not a no brainer.

Infinite Scale is a product to do "Secure File Sync and Share", enhanced by WebOffice capabilities.

Thumbnails for videos is debatable in that scope.

  1. The added value of a small random thumbnail which only represents a second from the video is not high
  2. The added resource use on the server is not proportional to the added value

From my product owner POV, I do not support that feature.

@kobergj @unbekanntes-pferd FYI

I would love to contribute but currently I dont have that time to work myself into the whole project.
Nevertheless I think the value is extremely high since I think most people use clouds not to host pdfs/excels but images and videos. You dont need a cloud for couple MBs of pdfs/word documents. And since you said "Secure File Sync and Share" it is right about this scope or not? How do you handle GB or TB of videos / images and want to share the right picture/video? Either you have to name all of them properly which is ages of work if you have automated sync and just uploading everything or you have to download every video to see if it is the right video. So sharing with other people is basically not possible. Furthermore I cant even watch .mov files directly but they get downloaded. So now I have to download GB of files just to delete them right after because I took the wrong

@micbar
Copy link
Contributor

micbar commented Nov 16, 2024

Sorry, seems that I wrote something wrong and don’t want to upset people…

Gigabytes of, data, media files, that is exactly what ocis is for.

I just said „the value of displaying a small preview image for a video file is not proportional to the effort“

I agree that everybody wants to have the best user experience possible.

But I have a clear picture what is needed to provide video decoding and transcoding and extracting that into a preview. On the backend it is maybe no big effort to code that, but it will blow up the dependencies, traffic and needed resources on the backend.

We have experience in running a large service for more the one million users. We know how we need to fight for every cpu cycle and memory which we can reduce.

I think something like that could be a good community initiative, but like said earlier, I don’t see this coming from owncloud.

@micbar
Copy link
Contributor

micbar commented Nov 16, 2024

How do you handle GB or TB of videos / images and want to share the right picture/video?

Metadata is the key. We are already extracting metadata from images and audio files. That together with tagging could help tremendously.

@vegaz337
Copy link

Sorry, seems that I wrote something wrong and don’t want to upset people…

Gigabytes of, data, media files, that is exactly what ocis is for.

I just said „the value of displaying a small preview image for a video file is not proportional to the effort“

I agree that everybody wants to have the best user experience possible.

But I have a clear picture what is needed to provide video decoding and transcoding and extracting that into a preview. On the backend it is maybe no big effort to code that, but it will blow up the dependencies, traffic and needed resources on the backend.

We have experience in running a large service for more the one million users. We know how we need to fight for every cpu cycle and memory which we can reduce.

I think something like that could be a good community initiative, but like said earlier, I don’t see this coming from owncloud.

Thanks for your concern, dont worry you didnt upset me. Im just trying to find a solution since initially you asked for a library without C dependencies and I threw in some suggestions. I would love to have a solution where everyone is happy at the end of the day. If metadata somehow do it that would be great but currently I dont see how I would know which video exactly im looking for through that. Because in 2 years im sure I dont know anymore when and where I made this exact video. Maybe you can get me some knowledge here.

@ThesiiNCey
Copy link
Author

There have been some good changes and improvements so far, but is it now possible to see videos and WEP images as previews? I've lost track of how many issues there are to really understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

No branches or pull requests

8 participants