Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sharing-ng: Emtpy sharedWithMe response when received shares contain share from project space #8215

Closed
rhafer opened this issue Jan 16, 2024 · 1 comment · Fixed by #8233
Closed

sharing-ng: Emtpy sharedWithMe response when received shares contain share from project space #8215

rhafer opened this issue Jan 16, 2024 · 1 comment · Fixed by #8233
Assignees
@rhafer
Labels
Type:Bug
Milestone
Release 5.0.0

Comments

@rhafer
Copy link
Contributor

rhafer commented Jan 16, 2024

When one of the received shares is a share from a project space the API will just return a 404 (it seems the owner of the shared item is not a valid userid but the project space id)

{
	"error": {
		"code": "itemNotFound",
		"innererror": {
			"date": "2024-01-10T16:06:33Z",
			"request-id": "23a8b0919805/ArGUHkKdIn-000002"
		},
		"message": "not found"
	}
}
@rhafer rhafer self-assigned this Jan 16, 2024
@rhafer rhafer moved this from Qualification to In progress in Infinite Scale Team Board Jan 16, 2024
@rhafer rhafer mentioned this issue Jan 16, 2024
Merged
8 tasks
@rhafer
Copy link
Contributor Author

rhafer commented Jan 17, 2024 •
edited
Loading

related issue #6993

rhafer added a commit to rhafer/ocis that referenced this issue Jan 17, 2024
@rhafer
graph/sharedWitMe: fix response for shares from project space
5031479 
Resources on project space do not have a real owner assigned. A special
of the type USER_TYPE_SPACE_OWNER is returned as the owner. This type of
user can't be looked up via a GetUser request. So we skip that call for
this usertype.

This also fixes the behavior of 'sharedWithMe' for case when the owner
or creator of a share or shared resource can't be looked up in the 'users'
service. Previously cause the complete request to fail with an error message.
So a single share with an unresolvable owner caused 'sharedWithMe' to fail.
Now we log a warning but return all shares. Those where the owner or creator
couldn't be resolved will have the 'displayName' field of the user in the
'remoteItem.shared.owner' or 'remoteItem.shared.sharedBy' property left
empty.

Fixes: owncloud#8215
Fixes: owncloud#8027
@rhafer rhafer mentioned this issue Jan 17, 2024
Merged
rhafer added a commit to rhafer/ocis that referenced this issue Jan 17, 2024
@rhafer
graph/sharedWitMe: fix response for shares from project space
95d40c3 
Resources on project space do not have a real owner assigned. A special
of the type USER_TYPE_SPACE_OWNER is returned as the owner. This type of
user can't be looked up via a GetUser request. So we skip that call for
this usertype.

This also fixes the behavior of 'sharedWithMe' for case when the owner
or creator of a share or shared resource can't be looked up in the 'users'
service. Previously cause the complete request to fail with an error message.
So a single share with an unresolvable owner caused 'sharedWithMe' to fail.
Now we log a warning but return all shares. Those where the owner or creator
couldn't be resolved will have the 'displayName' field of the user in the
'remoteItem.shared.owner' or 'remoteItem.shared.sharedBy' property left
empty.

Fixes: owncloud#8215
Fixes: owncloud#8027
rhafer added a commit that referenced this issue Jan 19, 2024
@rhafer
graph/sharedWitMe: fix response for shares from project space
0e1b5dd 
Resources on project space do not have a real owner assigned. A special
of the type USER_TYPE_SPACE_OWNER is returned as the owner. This type of
user can't be looked up via a GetUser request. So we skip that call for
this usertype.

This also fixes the behavior of 'sharedWithMe' for case when the owner
or creator of a share or shared resource can't be looked up in the 'users'
service. Previously cause the complete request to fail with an error message.
So a single share with an unresolvable owner caused 'sharedWithMe' to fail.
Now we log a warning but return all shares. Those where the owner or creator
couldn't be resolved will have the 'displayName' field of the user in the
'remoteItem.shared.owner' or 'remoteItem.shared.sharedBy' property left
empty.

Fixes: #8215
Fixes: #8027
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Jan 19, 2024
ownclouders pushed a commit that referenced this issue Jan 19, 2024
@rhafer
graph/sharedWitMe: fix response for shares from project space
d4c4f06 
Resources on project space do not have a real owner assigned. A special
of the type USER_TYPE_SPACE_OWNER is returned as the owner. This type of
user can't be looked up via a GetUser request. So we skip that call for
this usertype.

This also fixes the behavior of 'sharedWithMe' for case when the owner
or creator of a share or shared resource can't be looked up in the 'users'
service. Previously cause the complete request to fail with an error message.
So a single share with an unresolvable owner caused 'sharedWithMe' to fail.
Now we log a warning but return all shares. Those where the owner or creator
couldn't be resolved will have the 'displayName' field of the user in the
'remoteItem.shared.owner' or 'remoteItem.shared.sharedBy' property left
empty.

Fixes: #8215
Fixes: #8027
@micbar micbar added this to the Release 5.0.0 milestone Jan 22, 2024
@amrita-shrestha amrita-shrestha mentioned this issue Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhafer rhafer

Labels
Type:Bug
Projects
Infinite Scale Team Board
Archived in project
Milestone
Release 5.0.0
Development

Successfully merging a pull request may close this issue.

graph/sharedWitMe: fix response for shares from project space rhafer/ocis
2 participants
@rhafer @micbar