Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userinfo cache does not check for expiry #8297

Closed
kobergj opened this issue Jan 26, 2024 · 0 comments
Closed

Userinfo cache does not check for expiry #8297

kobergj opened this issue Jan 26, 2024 · 0 comments
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Topic:Security Type:Bug
Milestone

Comments

@kobergj
Copy link
Collaborator

kobergj commented Jan 26, 2024

The userinfo cache, which caches the oidc tokens in the proxy service has only a ttl of 10s. This is because is don't check the expiry of cached tokens. It relied on a ttl it set per record, but this is not working in nats-js-kv

The proxy service should check the expiration even if it pulled it from the cache. This would allow us to increase the ttl and reduce pressure on the idp

@micbar micbar added Priority:p2-high Escalation, on top of current planning, release blocker Topic:Security labels Jan 26, 2024
@micbar micbar moved this from Qualification to Prio 2 in Infinite Scale Team Board Jan 26, 2024
@micbar micbar added this to the Release 5.0.0 milestone Jan 26, 2024
@butonic butonic self-assigned this Jan 29, 2024
@butonic butonic closed this as completed Jan 31, 2024
@github-project-automation github-project-automation bot moved this from Prio 2 to Done in Infinite Scale Team Board Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Topic:Security Type:Bug
Projects
Archived in project
Development

No branches or pull requests

3 participants