Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify expiry of cached claims #8310

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

butonic
Copy link
Member

@butonic butonic commented Jan 29, 2024

This PR verifies the expiry of claims retrieved from the cache.

Before adding tests I need to bump the mockito cmd and the way we generate mocks. Things have changed a lot there.

Copy link

update-docs bot commented Jan 29, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic force-pushed the verify-expiry-of-cached-claims branch 2 times, most recently from 8ce7e45 to a725a53 Compare January 29, 2024 16:16
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic force-pushed the verify-expiry-of-cached-claims branch from a725a53 to 06bc545 Compare January 30, 2024 09:43
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@butonic
Copy link
Member Author

butonic commented Jan 31, 2024

fixes #8297

@butonic butonic merged commit 45d1936 into master Jan 31, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the verify-expiry-of-cached-claims branch January 31, 2024 13:58
ownclouders pushed a commit that referenced this pull request Jan 31, 2024
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants