Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thumbnailer frequently rejecting portrait mode images #9234

Closed
kulmann opened this issue May 22, 2024 · 1 comment · Fixed by #9360
Closed

Thumbnailer frequently rejecting portrait mode images #9234

kulmann opened this issue May 22, 2024 · 1 comment · Fixed by #9360
Assignees
@kulmann
Labels
Priority:p3-medium Normal priority Type:Bug

Comments

@kulmann
Copy link
Contributor

kulmann commented May 22, 2024

Describe the bug

With #9069 scan limitations for image width and height were introduced to the thumbnail service. However, the width to height aspect ratio is favouring landscape mode images over portrait mode images. ;-)

Steps to reproduce

  1. Upload a portrait mode image from a low price segment DSLR
  2. Try to see a thumbnail or open the image in the preview app

Expected behavior

Our defaults work for thumbnail generation for images from for this kind of camera

Actual behavior

Our defaults are too restrictive for portrait mode images
Image width and height should be the same value, so that thumbnail generation works for both landscape and portrait mode images.
@kulmann kulmann moved this from Qualification to Prio 3 or less in Infinite Scale Team Board May 22, 2024
@jnweiger
Copy link
Contributor

See also: https://central.owncloud.org/t/cannot-view-vertical-photos-on-the-web-side/47758/2

kulmann added a commit that referenced this issue Jun 12, 2024
@kulmann
fix: thumbnail max input height
7276e94 
Thumbnail max input width and height need to be the same, because images
can be portrait or landscape. See #9234
@kulmann kulmann mentioned this issue Jun 12, 2024
Merged
9 tasks
kulmann added a commit that referenced this issue Jun 12, 2024
@kulmann
fix: thumbnail max input height
6117e19 
Thumbnail max input width and height need to be the same, because images
can be portrait or landscape. See #9234
@kulmann kulmann assigned kulmann and unassigned DeepDiver1975 Jun 12, 2024
@github-project-automation github-project-automation bot moved this from Prio 3 or less to Done in Infinite Scale Team Board Jun 12, 2024
rhafer pushed a commit to rhafer/ocis that referenced this issue Oct 9, 2024
@kulmann @rhafer
fix: thumbnail max input height
916d067 
Thumbnail max input width and height need to be the same, because images
can be portrait or landscape. See owncloud#9234

(cherry picked from commit 6117e19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kulmann kulmann

Labels
Priority:p3-medium Normal priority Type:Bug
Projects
Infinite Scale Team Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: thumbnail max input height owncloud/ocis
3 participants
@DeepDiver1975 @jnweiger @kulmann