Use idp logo from theme #10274
Merged
Use idp logo from theme #10274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
AlexAndBear
commented
Oct 9, 2024
AlexAndBear
force-pushed
the
idp-use-theme-logo
branch
4 times, most recently
from
41387bc to
15864e0
Compare
AlexAndBear
commented
Oct 9, 2024
JammingBen
reviewed
Oct 10, 2024
There was a problem hiding this comment.
On a fresh instance (remove .ocis folder and re-init) it tries to fetch the default logo from themes/owncloud/assets/logo.svg, which doesn't exist. Does it happen for you as well, or just on my end?
Edit: ah, I assume it's only happening to me because of the web config file I'm using.
Edit2: or not, still having this issue without specifying a web config file.
JammingBen
approved these changes
Oct 10, 2024
AlexAndBear
force-pushed
the
idp-use-theme-logo
branch
from
83a4573 to
0105739
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: