Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'OCM_OCM_PROVIDER_AUTHORIZER_VERIFY_REQUEST_HOSTNAME' setting #10425

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Oct 28, 2024

The feature never really worked correctly and it's added value is at least arguable.

I think we do not need to go through the usual deprecation cycle here since the feature was not really working at any time. If you disagree please holler.

For details see #10355

The feature never really worked correctly and it's added value is at least
arguable.

Fixes owncloud#10355
@rhafer rhafer self-assigned this Oct 28, 2024
Copy link

@rhafer rhafer marked this pull request as ready for review October 28, 2024 11:10
@rhafer rhafer requested review from mmattel and wkloucek October 28, 2024 11:11
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ok from a docs pov 👍

@rhafer rhafer requested review from butonic and mmattel October 28, 2024 11:29
@2403905 2403905 merged commit a80768e into owncloud:master Oct 28, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Oct 28, 2024
Remove 'OCM_OCM_PROVIDER_AUTHORIZER_VERIFY_REQUEST_HOSTNAME' setting
@wkloucek wkloucek mentioned this pull request Oct 30, 2024
11 tasks
@saw-jan saw-jan mentioned this pull request Nov 8, 2024
9 tasks
This was referenced Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants