Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart Postprocessing Properly #10439

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Oct 29, 2024

Allows differentiating between "restart" and "resume" postprocessing

@mmattel
Copy link
Contributor

mmattel commented Oct 30, 2024

@kobergj this is docs relevant, needs a change in: https://github.com/owncloud/ocis/tree/master/services/postprocessing#cli-commands
I also referenced the admin docs, beause we have a listing of changed CLI here too.

@wkloucek
Copy link
Contributor

Allows differentiating between "restart" and "resume" postprocessing

Would the oCIS chart need have another CronJob next to ocis storage-users uploads sessions --restart --processing=true (https://github.com/owncloud/ocis-charts/blob/ce1b1c183b37bfda17f3114fce90b1f0f885da04/charts/ocis/templates/storageusers/jobs.yaml#L262C22-L262C95), that also calls the resume command?

I'm a little bit confused what actually needs to be run to cater all the different "postprocessing stuck" situations that can happen.

@kobergj
Copy link
Collaborator Author

kobergj commented Oct 30, 2024

restart will restart post processing of an upload from the very beginning. This allows retrying otherwise stuck uploads.

resume will resume postprocessing from the last finished step. This will cost less resources but doesn't work in all cases.

You could always call restart or call resume in specific situations to save resources.

@kobergj kobergj marked this pull request as ready for review October 30, 2024 14:07
@kobergj
Copy link
Collaborator Author

kobergj commented Oct 30, 2024

I'll prepare a hotfix once this is merged. This should enable us to get the files back.

@kobergj
Copy link
Collaborator Author

kobergj commented Nov 4, 2024

@wkloucek should we merge this so I can proceed with the backport? Or you have additional suggestions?

Copy link

sonarqubecloud bot commented Nov 4, 2024

@kobergj kobergj merged commit e85a8b9 into owncloud:master Nov 4, 2024
4 checks passed
@kobergj kobergj deleted the RestartPPReworked branch November 4, 2024 13:23
ownclouders pushed a commit that referenced this pull request Nov 4, 2024
@micbar micbar mentioned this pull request Nov 8, 2024
85 tasks
@ScharfViktor
Copy link
Contributor

tested during the Patch release 5.0.9
ocis/bin/ocis postprocessing resume - works
ocis/bin/ocis postprocessing restart - works

I understand diffirence between commands but couldn't find the way how to test it localy

@ScharfViktor ScharfViktor mentioned this pull request Nov 12, 2024
17 tasks
@micbar micbar mentioned this pull request Dec 17, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants