Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-only] Improve error messages for health command output #10566

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Nov 14, 2024

When there is an issue reported from a ocis <service-name> health command, we should advice to run ocis init --diff and not ocis init. The diff option will only generate a patchable delta file which can be reviewed and applied while an init without diff will overwrite the config.

We do the same when upgrading...

@mmattel mmattel changed the title [docs-only] Imporve error messages for health command output [docs-only] Improve error messages for health command output Nov 14, 2024
@mmattel mmattel force-pushed the improve_health_error_message branch from 28b34d1 to 168f1a8 Compare November 14, 2024 10:10
@mmattel mmattel enabled auto-merge November 14, 2024 10:11
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Bugs (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mmattel
Copy link
Contributor Author

mmattel commented Nov 14, 2024

Sonarcloud reports that string content is repeating and could be moved into a constant...
This existed before too. Should we consider changing this? (If, I need some help)

@mmattel mmattel merged commit 3a1ced1 into master Nov 14, 2024
3 of 4 checks passed
@dragonchaser dragonchaser deleted the improve_health_error_message branch November 14, 2024 13:37
ownclouders pushed a commit that referenced this pull request Nov 14, 2024
[docs-only] Improve error messages for health command output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants