Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thumbnails status code #10592

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix thumbnails status code #10592

merged 1 commit into from
Nov 18, 2024

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Nov 18, 2024

Return 403 instead of 500 when the image is too large (in dimensions or file size).

@rhafer rhafer self-assigned this Nov 18, 2024
@rhafer rhafer marked this pull request as ready for review November 18, 2024 12:17
@2403905
Copy link
Contributor

2403905 commented Nov 18, 2024

Why 403 but not 400 or 413? Found a discusion

Return 403 instead of 500 when the image is too large (in dimensions or file
size).

Fixes: owncloud#10589
@rhafer rhafer enabled auto-merge (rebase) November 18, 2024 14:59
@rhafer rhafer merged commit e0cf17d into owncloud:master Nov 18, 2024
4 checks passed
@rhafer rhafer deleted the issue/10589 branch November 18, 2024 15:18
@micbar micbar mentioned this pull request Nov 21, 2024
85 tasks
@micbar micbar mentioned this pull request Dec 17, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants