Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] cleanup unnecessary env variables #10628

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Nov 22, 2024

Description

  • remove test env variables that are not required anymore
  • error handling ldap user/group creation
  • remove unnecessary log lines

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

tests: remove unnecessary logs
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
could you run please with [full-ci] to make sure everything's in order.

it's a good idea to remove the extras from drone.star
I found unnecessary volumes section: https://github.com/owncloud/ocis/blob/master/.drone.star#L2784-L2836

@saw-jan
Copy link
Member Author

saw-jan commented Nov 22, 2024

could you run please with [full-ci] to make sure everything's in order.

yeah, I missed that

I found unnecessary volumes section: https://github.com/owncloud/ocis/blob/master/.drone.star#L2784-L2836

I will cleanup that in coming PRs

@saw-jan
Copy link
Member Author

saw-jan commented Nov 22, 2024

could you run please with [full-ci] to make sure everything's in order.

yeah, I missed that

with full-ci we only get extra e2e-tests-multi-service pipeline. This should be unaffected by these changes.
SO I would like to merge this because we need this for ocis bump in reva (which was on hold for a long): cs3org/reva#4957

@@ -7,40 +7,29 @@ git config --global advice.detachedHead false

## CONFIGURE TEST

if [ "$TEST_SOURCE" = "oc10" ]
then
if [ "$TEST_SOURCE" = "oc10" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need oc10

Suggested change
if [ "$TEST_SOURCE" = "oc10" ]; then

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not required. just a leftover code. But we might want to decide to clean or completely remove these files (see #10530)

@saw-jan saw-jan merged commit 59e2605 into master Nov 22, 2024
2 checks passed
@saw-jan saw-jan deleted the tests/test-changes-reva branch November 22, 2024 11:01
ownclouders pushed a commit that referenced this pull request Nov 22, 2024
[tests-only] cleanup unnecessary env variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants