-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] cleanup unnecessary env variables #10628
Conversation
tests: remove unnecessary logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
could you run please with [full-ci] to make sure everything's in order.
it's a good idea to remove the extras from drone.star
I found unnecessary volumes section: https://github.com/owncloud/ocis/blob/master/.drone.star#L2784-L2836
yeah, I missed that
I will cleanup that in coming PRs |
with |
@@ -7,40 +7,29 @@ git config --global advice.detachedHead false | |||
|
|||
## CONFIGURE TEST | |||
|
|||
if [ "$TEST_SOURCE" = "oc10" ] | |||
then | |||
if [ "$TEST_SOURCE" = "oc10" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need oc10
if [ "$TEST_SOURCE" = "oc10" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not required. just a leftover code. But we might want to decide to clean or completely remove these files (see #10530)
[tests-only] cleanup unnecessary env variables
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: