Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filtering of userlog based on settings #10779

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Add filtering of userlog based on settings #10779

merged 1 commit into from
Dec 23, 2024

Conversation

bastianbeier
Copy link
Contributor

@bastianbeier bastianbeier commented Dec 17, 2024 •
edited
Loading

Description

Add filtering of userlog based on settings. Should be merged after #10706

Related Issue

How Has This Been Tested?

  • test environment: localhost
  • test case 1: unshare space with user that has in-app notifications for space unshared disabled

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs Update Docs
Copy link

update-docs bot commented Dec 17, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@bastianbeier bastianbeier force-pushed the issue-10769 branch 2 times, most recently from 5d2cc9c to 8ae87c4 Compare December 17, 2024 17:01
@2403905 2403905 requested a review from kobergj December 18, 2024 09:34
kobergj
kobergj requested changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nitpicking as always. Rest looks 👍

services/userlog/pkg/service/filter.go Outdated Show resolved Hide resolved
services/userlog/pkg/service/filter.go Outdated Show resolved Hide resolved
services/userlog/pkg/service/filter.go Outdated Show resolved Hide resolved
@bastianbeier bastianbeier self-assigned this Dec 18, 2024
@bastianbeier
Copy link
Contributor Author

Thanks for the review!
Findings should be fixed @2403905 @kobergj

@bastianbeier bastianbeier requested a review from kobergj December 18, 2024 11:54
@mmattel mmattel mentioned this pull request Dec 18, 2024
Merged
9 tasks
@kobergj kobergj mentioned this pull request Dec 19, 2024
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kobergj
kobergj approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ❤️

@kobergj kobergj merged commit f052fb9 into owncloud:master Dec 23, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Dec 23, 2024
@kobergj
Merge pull request #10779 from bastianbeier/issue-10769
5793700 
Add filtering of userlog based on settings
@kobergj kobergj mentioned this pull request Dec 23, 2024
Open
15 tasks
@2403905 2403905 mentioned this pull request Jan 10, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2403905 2403905 2403905 left review comments

@mmattel mmattel mmattel left review comments

@kobergj kobergj kobergj approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

Assignees

@bastianbeier bastianbeier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow filtering notifications in userlog service
4 participants
@bastianbeier @mmattel @2403905 @kobergj