Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filtering of mails based on settings #10792

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Add filtering of mails based on settings #10792

merged 1 commit into from
Dec 23, 2024

Conversation

bastianbeier
Copy link
Contributor

@bastianbeier bastianbeier commented Dec 19, 2024 •
edited
Loading

Description

Add filtering of mails based on settings. Should be merged after #10706

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment: localhost
  • test case 1: create share for user who has enabled mail for create share event
  • test case 2: create share for user who has disabled mail for create share event

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@bastianbeier bastianbeier self-assigned this Dec 19, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kobergj
kobergj approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like 🚀

@kobergj kobergj merged commit 87a533a into owncloud:master Dec 23, 2024
4 checks passed
@kobergj kobergj mentioned this pull request Dec 23, 2024
Open
@2403905 2403905 mentioned this pull request Jan 10, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

Assignees

@bastianbeier bastianbeier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add filtering on notifications based on settings
2 participants
@bastianbeier @kobergj