-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grouped email notifications #10838
Grouped email notifications #10838
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
TODO:
|
&cli.BoolFlag{ | ||
Name: "weekly", | ||
Aliases: []string{"w"}, | ||
Usage: "Sends grouped weekly email notifications.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does weekly mean in this context? I'd expect notifications with a creation date within the "last 7 days" / last 168 hours!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
daily
and weekly
are just groups. You can trigger the sending of a group using the notifications send-email --daily
or notifications send-email --weekly
cli command.
You could also trigger the weekly job every 4 days or every 8 days but you have to consider the TTL of the events in the store when triggering not that often.
b586f39
to
44f7811
Compare
44f7811
to
d4274e9
Compare
d4274e9
to
a3b9935
Compare
@bastianbeier @2403905 do we consider the sonarcloud warnings false positives? |
a3b9935
to
8e89a34
Compare
72c3e30
to
4b76453
Compare
Co-authored-by: Martin <[email protected]>
Quality Gate passedIssues Measures |
Grouped email notifications
Description
Allow grouping of multiple events in a single email.
Needs to be merged after #10838
Related Issue
#10793
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: