Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocis and proxy are the only extensions which have a default for tracing endpoints. There shouldn't be a default at all, because there is a comparison if OCIS_TRACING_COLLECTOR is empty:
ocis/proxy/pkg/command/server.go
Lines 81 to 89 in a591d65
Which calls this: https://github.com/census-ecosystem/opencensus-go-exporter-jaeger/blob/30c8b0fe8ad9d0eac5785893f3941b2e72c5aaaa/jaeger.go#L88-L98
For example if you want to use OCIS_TRACING_ENDPOINT at the moment you have to explicitly override OCIS_TRACING_COLLECTOR with an empty string. The configuration looks like this:
After the merge this would look like this:
Loosely related: cs3org/reva#1379