Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI-only] suppress bash: go: command not found warnings #1778

Merged
merged 1 commit into from
Mar 12, 2021
Merged

[CI-only] suppress bash: go: command not found warnings #1778

merged 1 commit into from
Mar 12, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Mar 9, 2021 •
edited
Loading

Description

CI produces a lot of bash: go: command not found warnings in the make ci-node-generate steps since merge of PR #1714.
This is because these pipeline steps don't have Go installed but the .bingo/Variables.mk which is included in every Makefile tests for the existence of Go. This included dependency is only needed if Go tooling is used and therefore Go must be available.

The warnings will be suppressed by conditionally including the Bingo Makefile if Go is present.

Related Issue

Motivation and Context

How Has This Been Tested?

  • See CI run

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Mar 9, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek force-pushed the fix_ci_go_warnings branch 3 times, most recently from 497d159 to ae99897 Compare March 9, 2021 09:54
@wkloucek wkloucek changed the title conditionally include bingo [CI-only] suppress bash: go: command not found warnings Mar 9, 2021
@wkloucek wkloucek force-pushed the fix_ci_go_warnings branch from ae99897 to d1701b3 Compare March 9, 2021 10:01
@wkloucek wkloucek marked this pull request as ready for review March 9, 2021 10:02
@wkloucek wkloucek requested a review from LukasHirt as a code owner March 9, 2021 10:02
@wkloucek wkloucek requested review from refs and phil-davis March 9, 2021 10:02
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit d922c12 into master Mar 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_ci_go_warnings branch March 12, 2021 14:57
ownclouders pushed a commit that referenced this pull request Mar 12, 2021
@wkloucek
commit d922c12
2347c44 
Merge: 77bf0d4 d1701b3
Author: Willy Kloucek <[email protected]>
Date:   Fri Mar 12 15:57:55 2021 +0100

    Merge pull request #1778 from owncloud/fix_ci_go_warnings

    [CI-only] suppress `bash: go: command not found` warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

@refs refs Awaiting requested review from refs

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @micbar