Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-only] fix ci docs #1781

Merged
merged 1 commit into from
Mar 9, 2021
Merged

[docs-only] fix ci docs #1781

merged 1 commit into from
Mar 9, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Mar 9, 2021 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Mar 9, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested review from C0rby, fschade and phil-davis March 9, 2021 10:30
phil-davis
phil-davis approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree - the upstream release seems to be never going to happen, so documenting this "workaround" is good.

@phil-davis phil-davis merged commit 253e180 into master Mar 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_ci_docs branch March 9, 2021 11:57
ownclouders pushed a commit that referenced this pull request Mar 9, 2021
@phil-davis
commit 253e180
55ea789 
Merge: 0eda3b8 84888eb
Author: Phil Davis <[email protected]>
Date:   Tue Mar 9 17:42:53 2021 +0545

    Merge pull request #1781 from owncloud/fix_ci_docs

    [docs-only] fix ci docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@C0rby C0rby Awaiting requested review from C0rby

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @phil-davis