Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added labels for username and password input in idp service #1794

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Added labels for username and password input in idp service #1794

merged 2 commits into from
Mar 12, 2021

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 11, 2021 •
edited by kulmann
Loading

Description

Added labels and aria-invalid + aria-described by to username and password input fields

Related Issue

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Mar 11, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from kulmann March 11, 2021 08:36
@AlexAndBear AlexAndBear self-assigned this Mar 11, 2021
@AlexAndBear AlexAndBear marked this pull request as ready for review March 11, 2021 09:51
kulmann
kulmann suggested changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Especially accessibility wise good solution 👍 Some minor proposals as comments. Also: please run make generate again with the final source version.

changelog/unreleased/add-labels-and-aria-labelled-by-on-login.md Outdated Show resolved Hide resolved
idp/ui/src/app.css Outdated Show resolved Hide resolved
@AlexAndBear AlexAndBear requested a review from kulmann March 11, 2021 12:05
@AlexAndBear
Copy link
Contributor Author

:) 👍 resolved

@AlexAndBear
Copy link
Contributor Author

Also fixes https://jira.owncloud.com/browse/WEB-107

@AlexAndBear AlexAndBear force-pushed the issues/WEB-105 branch 2 times, most recently from cbe7395 to 1a4f8aa Compare March 12, 2021 10:29
@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Mar 12, 2021 •
edited
Loading

@kulmann
Added red borders on error state
Changed translation texts

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultra nitpick: there is some wrong whitespace (see comment). Other than that: 😍

idp/ui/src/containers/Login/Login.js

return (
<form action="" onSubmit={(event) => this.logon(event)}>
return (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace doesn't look intentional. Happened by accident?

@kulmann kulmann merged commit ee9457c into master Mar 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/WEB-105 branch March 12, 2021 15:46
ownclouders pushed a commit that referenced this pull request Mar 12, 2021
@kulmann
commit ee9457c
abd5935 
Merge: d922c12 de9b43e
Author: Benedikt Kulmann <[email protected]>
Date:   Fri Mar 12 16:46:27 2021 +0100

    Merge pull request #1794 from owncloud/issues/WEB-105

    Added labels for username and password input in idp service
@fschade fschade mentioned this pull request Mar 29, 2021
Closed
17 tasks
@pascalwengerter pascalwengerter mentioned this pull request Jun 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@AlexAndBear AlexAndBear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAndBear @kulmann